[docs] Improve Font Awesome integration #22496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
reviewed
Sep 5, 2020
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
docs/font-awesome-svg-icon-next
branch
from
5804a73
to
079c7c5
Compare
oliviertassinari
approved these changes
Sep 7, 2020
| <Icon className="fa fa-plus-circle" color="secondary" /> | ||
| <Icon className="fa fa-plus-circle" style={{ color: green[500] }} /> | ||
| <Icon className="fa fa-plus-circle" fontSize="small" /> | ||
| <Icon className="fa fa-plus-circle" style={{ fontSize: 30 }} /> |
| @@ -7,20 +7,21 @@ import Icon from '@material-ui/core/Icon'; | |||
| const useStyles = makeStyles((theme: Theme) => | |||
| createStyles({ | |||
| root: { | |||
| '& > .fa': { | |||
| '& > *': { | |||
| @@ -217,8 +216,7 @@ export const styles = (theme) => { | |||
| deleteIcon: { | |||
| WebkitTapHighlightColor: 'transparent', | |||
| color: deleteIconColor, | |||
| height: 22, | |||
| width: 22, | |||
| fontSize: 22, | |||
There was a problem hiding this comment.
Needed to support font icons
oliviertassinari
force-pushed
the
docs/font-awesome-svg-icon-next
branch
from
079c7c5
to
9ad0552
Compare
oliviertassinari
force-pushed
the
docs/font-awesome-svg-icon-next
branch
from
9ad0552
to
a85f753
Compare
|
@chrislambe Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #17754 (comment).
Wanted to point out a couple things to focus on:
I had to add three packages to the
docsworkspace (@fortawesome/{fontawesome-svg-core,free-solid-svg-icons, react-fontawesome}) following the precedent set in theTextFielddocs: https://material-ui.com/components/text-fields/#integration-with-3rd-party-input-librariesMy
FontAwesomeSvgIconDemo.tsxwon't compile as written. It seems to be due to the declaration of theFontAwesomeSvgIconcomponent in the module. Here's the error:Compiler error
I was able to work around this by creating the
FontAwesomeSvgIconcomponent in theFontAwesomeSvgIconDemocomponent (viauseMemo) but that caused a failure in the linter about prop types, so I reverted to declaring the component at the module root. Interestingly, ifyarn docs:typescriptwas running and had already successfully compiled the demo once, it didn't have a problem, which is how I was able to complete the demo in the first place.Otherwise I think it's ready for review!
Closes #17754