Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES6 import/exports in docs #2253

Merged
merged 1 commit into from
Nov 24, 2015
Merged

Use ES6 import/exports in docs #2253

merged 1 commit into from
Nov 24, 2015

Conversation

sloria
Copy link
Contributor

@sloria sloria commented Nov 24, 2015

ref #1276

This doesn't change any source code; only the docs.

@oliviertassinari
Copy link
Member

Thanks!
Regarding SVG icon components, I think that you have missed a lot of them. Could you update the template and run the generation script?

@sloria
Copy link
Contributor Author

sloria commented Nov 24, 2015

Fixed. Let me know if there is anything else that needs to be done before this is merged.

@oliviertassinari
Copy link
Member

Thanks, I'm gonna test it.
@shaurya947 Why do we have those icons in the doc folder? Couldn't we use icons in the svg folder?

@shaurya947
Copy link
Contributor

@oliviertassinari good point. We very well could use the icons under src/svg-icons

@oliviertassinari
Copy link
Member

@sloria Looks good 👍!

oliviertassinari added a commit that referenced this pull request Nov 24, 2015
@oliviertassinari oliviertassinari merged commit 2c711af into mui:master Nov 24, 2015
@oliviertassinari
Copy link
Member

@sloria I also think that we should use import on the src folder. It would make more sense.
As you may have seens, the code base is not very coherent. I'm working on it. I'm enforcing more and more eslint rules.

@sloria
Copy link
Contributor Author

sloria commented Nov 30, 2015

Glad to hear it.

@alitaheri alitaheri mentioned this pull request Dec 7, 2015
@zannager zannager added the docs Improvements or additions to the documentation label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants