Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Autocomplete] Fix interfaces in the Google Maps demo #22555

Merged
merged 1 commit into from Sep 10, 2020
Merged

[Autocomplete] Fix interfaces in the Google Maps demo #22555

merged 1 commit into from Sep 10, 2020

Conversation

L-U-C-K-Y
Copy link
Contributor

@L-U-C-K-Y L-U-C-K-Y commented Sep 10, 2020 •
edited

Hi all

Copying the demo into our project was causing issues with the newest typescript version.

We were receiving:

Failed to compile.
./src/components/placesAutoComplete.tsx
Syntax error: Cannot read property 'map' of undefined (0:undefined)

By separating the interfaces, we were able to resolve this issue and successfully build our project.

Keep up the great work Material-UI team! You guys are awesome!

@mui-pr-bot
Copy link

No bundle size changes comparing 27fe6a3...97a9e84

Generated by 🚫 dangerJS against 97a9e84

@oliviertassinari oliviertassinari changed the title fix(GoogleMaps): fixed interfaces in the Google Maps demo [Autocomplete] Fix interfaces in the Google Maps demo Sep 10, 2020
@oliviertassinari oliviertassinari added component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript labels Sep 10, 2020
@oliviertassinari oliviertassinari merged commit af71e84 into mui:next Sep 10, 2020
@oliviertassinari
Copy link
Member

@L-U-C-K-Y It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@L-U-C-K-Y @mui-pr-bot @oliviertassinari @LucBas