Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select] Improve docs for displayEmpty prop #22601

Merged
merged 4 commits into from Sep 17, 2020
Merged

[Select] Improve docs for displayEmpty prop #22601

merged 4 commits into from Sep 17, 2020

Conversation

mihaipanait
Copy link
Contributor

@mihaipanait mihaipanait commented Sep 15, 2020 •
edited by oliviertassinari

Fix #22596

@mui-pr-bot
Copy link

mui-pr-bot commented Sep 15, 2020 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 43c2fd6

@github-actions github-actions bot mentioned this pull request Sep 15, 2020
Closed
@oliviertassinari oliviertassinari added component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Sep 15, 2020
@oliviertassinari oliviertassinari changed the title [Select] Update documentation for displayEmpty prop [Select] Improve docs for displayEmpty prop Sep 15, 2020
eps1lon
eps1lon previously requested changes Sep 15, 2020
View reviewed changes
packages/material-ui/src/Select/Select.js Outdated Show resolved Hide resolved
packages/material-ui/src/Select/Select.js Outdated Show resolved Hide resolved
@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 15, 2020 •
edited

@mihaipanait The two solutions for outlined (1. shrink) and filled (2. no visible label) https://codesandbox.io/s/material-demo-forked-qrz7x?file=/demo.tsx.

From my perspective, it's not worth pushing further. I can't remember why we have introduced the support for displayEmpty in the first place, maybe it was a mistake.

@oliviertassinari oliviertassinari merged commit 20b5739 into mui:next Sep 17, 2020
@oliviertassinari
Copy link
Member

@mihaipanait Thanks for participating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees
No one assigned
Labels
component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Select] Do not render correctly when displayEmpty is set to true
4 participants
@mihaipanait @mui-pr-bot @oliviertassinari @eps1lon