Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Use codesandbox deploy for demos created from deploy previews #22616

Merged
merged 1 commit into from Sep 16, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 16, 2020

When creating a codesandbox from a demo in a netlify deploy preview i.e. deployed PRs we'll now use the packages built from the same PR. Before you would always create demos using the latest published version on NPM.

I could've used this a couple of times in the past when doing extensive manual testing i.e. manual e2e testing. Our capabilities are already limited for local testing but you could always work around it. It's more a convenience functionality when reviewing PRs.

Downside:

  • deploy preview behaves different than actual published docs
  • can be confusing when docs deploy finishes before codesandbox

Alternative:
Leave original functionality untouched but add an extra button in the "misc menu" for creating the demo using codesandbox deploys.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Sep 16, 2020
@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against 750d354

Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It's exactly what we discussed a few months ago with @mnajdova when she was working on the CSS utility classes and couldn't test it in code sandbox.

@eps1lon
Copy link
Member Author

eps1lon commented Sep 16, 2020

It's exactly what we discussed a few months ago with @mnajdova when she was working on the CSS utility classes and couldn't test it in code sandbox.

Right, I already forgot. Though you could always test it. You just had to know where to look for. Discoverability was almost non-existent. Hope this improves things. We'll need to make sure the deploy works. Booleans in environment variables are always a bit sketchy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants