Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add additional context to Autocomplete asynchronous documentation #22621

Merged
merged 4 commits into from Sep 17, 2020
Merged

[docs] Add additional context to Autocomplete asynchronous documentation #22621

merged 4 commits into from Sep 17, 2020

Conversation

jaebradley
Copy link
Contributor

@jaebradley jaebradley commented Sep 16, 2020 •
edited

Summary

Closes #20068.

Basically implements the suggested documentation updates detailed in this comment: #20068 (comment)

image

@oliviertassinari oliviertassinari added component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation labels Sep 16, 2020
@github-actions github-actions bot mentioned this pull request Sep 16, 2020
Closed
@mui-pr-bot
Copy link

No bundle size changes comparing 8452e71...a38ecf5

Generated by 🚫 dangerJS against a38ecf5

@oliviertassinari oliviertassinari merged commit c51c884 into mui:next Sep 17, 2020
@oliviertassinari
Copy link
Member

@jaebradley It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@jaebradley jaebradley deleted the issue-20068-update-autocomplete-documentation branch September 17, 2020 23:05
@brayanL
Copy link

brayanL commented Oct 20, 2020

@jaebradley thanks for your work this line saved my life.
filterOptions={(x) => x}
I don't know what exactly does, and I don't see that changes on official docs, but thanks a lot.

@sefrem
Copy link

sefrem commented Dec 29, 2020 •
edited

Weirdly enough there is still no mention of the filterOptions prop in the officisl docs. I knew that the filter problem arises from the internal working of Autocomplete but i had no idea i could bypass it with this prop.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 29, 2020 •
edited

@sefrem It's mentioned in https://next.material-ui.com/api/autocomplete/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Autocomplete] Not refreshing options (used with async calls)
6 participants
@jaebradley @mui-pr-bot @oliviertassinari @brayanL @sefrem @mnajdova