[docs] Migrate all templates to TypeScript #22650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
docs
Comment on lines
-27
to
-30
| renderRow.propTypes = { | ||
| index: PropTypes.number.isRequired, | ||
| style: PropTypes.object.isRequired, | ||
| }; |
There was a problem hiding this comment.
This is a render function, no propTypes should be added. See the diff in packages/typescript-to-proptypes/src/parser.ts. I think that it makes a great test case. I have work on this because the parsing on docs/src/pages/getting-started/templates/checkout/Checkout.tsx was failing. The issue in checkout is unrelated but instead of fixing it, I went on solving one with more benefits :).
| @@ -40,7 +40,7 @@ const mainFeaturedPost = { | |||
| description: | |||
| "Multiple lines of text that form the lede, informing new readers quickly and efficiently about what's most interesting in this post's contents.", | |||
| image: 'https://source.unsplash.com/random', | |||
| imgText: 'main image description', | |||
| imageText: 'main image description', | |||
There was a problem hiding this comment.
Thank you TypeScript for spotting this mistake.
| @@ -49,7 +49,7 @@ export default function FeaturedPost(props) { | |||
| <CardMedia | |||
| className={classes.cardMedia} | |||
| image={post.image} | |||
| title={post.imageTitle} | |||
| title={post.imageText} | |||
There was a problem hiding this comment.
Thank you TypeScript for spotting this mistake.
| <Typography variant="h6" gutterBottom className={classes.sidebarSection}> | ||
| Social | ||
| </Typography> | ||
| {social.map((network) => ( | ||
| <Link display="block" variant="body1" href="#" key={network}> | ||
| <Link display="block" variant="body1" href="#" key={network.name}> |
There was a problem hiding this comment.
Thank you TypeScript for spotting this mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done to help make the case for: #22315.