[test] Run CircleCI anytime #22676
Merged
[test] Run CircleCI anytime #22676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No bundle size changes comparing 27ada08...5a00e40 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch filters are not as granular as with azure. We can't differentiate between pull requests and pushes with the branch name. Only PRs from other remotes follow the
pull/*branch naming scheme.The current
onlyand oldignoredidn't make sense since it would've prevented any CircleCI run (which we currently see on dependabot PRs).CircleCI should still auto-cancel builds on any branch but the default branch. If we continue to see large queues for the
l10n_*branches then we should contact support.Ideally we want:
masterandnextSo
l10n_nextwould only build once a PR is open and auto-cancel on new commits. This is how azure pipelines and netlify deploys work so I don't understand why CircleCI works different.