[Tooltip] Use label semantics #22729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
accessibility
|
Proposed changes in eps1lon#476 |
oliviertassinari
approved these changes
Sep 28, 2020
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Tooltip currently applies label and description semantics (
title+aria-describedby) which doesn't seem correct to me. It's apparent if you look at our usage in the docs where we passtitletoaria-label.This PR moves to label only semantics via
aria-labelfor string titles or aria-labelledby for anything else. For non-string titles you'd still need to label the child separately. But this was already the case before.It also gets rid of the problematic
titleattribute.It's unclear what SEO concerns this should solve.
Opening this for a11y testing and a11y snapshots diff in mui-scrips-incubator. In this form it can't land in v4 anyway. Also needs docs.