Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Batch small changes #22746

Merged
merged 4 commits into from Sep 28, 2020

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari added umbrella For grouping multiple issues to provide a holistic view core Infrastructure work going on behind the scenes labels Sep 26, 2020
@mui-pr-bot
Copy link

Details of bundle changes

Generated by 🚫 dangerJS against f7acfbc

@stefaluc
Copy link

@oliviertassinari Is there any way this could be included in the stable release as well (particularly 052a813), or would that be against your current release workflow?

@oliviertassinari
Copy link
Member Author

@stefaluc The objective of this commit was to simplify the logic (remove code), not to improve the behavior. doing down('xs') doesn't make sense, as far as I understand it.

@stefaluc
Copy link

stefaluc commented Jan 20, 2021

@oliviertassinari Thanks for the prompt response! I am trying to set custom breakpoints in my application but am receiving NaN values in my media queries. It looks like I mistakenly assumed this PR as the fix for this issue, when in actuality it looks like #21759 may be the fix I am looking for. So, same question, but with regards to #21759 instead 😁

@oliviertassinari
Copy link
Member Author

@stefaluc Honestly, we have done many iterations on improving the support for custom breakpoints. Even on v5, I suspect there are still issues.

@stefaluc
Copy link

@oliviertassinari Hmmm, I guess I'll just implement my own breakpoints outside of MUI then. I'd love to contribute if I can, but you saying that it's gone through many iterations leads me to believe that it would lie outside of my ability to make improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants