New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooltip] Improve docs and warning for custom children #22775
Conversation
@oliviertassinari @mbrookes I pushed a new commit because of the circle-ci:test_unit-1 failed. I think that it is solved in the correct way. I interpreted that the childrenProps['data-mui'] was introduced so that only the useEffect would be triggered if not in production. Was this the right way to go? Thanks in advance :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a new test? (I believe the last commit break the logic, so it sounds like we need a test to help assert it behave correctly :))
@oliviertassinari Okey, I could give it a try! So you mean that we should stick to the first commit, but add a new test in the Tooltip.test.js that covers the console.error? Or did you mean that we should stick to the last commit and add a test to that? |
@oliviertassinari sorry but I'm not really sure where this new test case should be placed, is it in the Tooltip.test.js? |
Yes. You can take a look at the other tests using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. But we should be careful with the name.
Co-authored-by: Matt <github@nospam.33m.co>
cca09c1
to
07dd649
Compare
@brorlarsnicklas Nice work, thanks! |
Closes #21324