[docs] Fix type vs. mode and capitalization of createMuiTheme #22844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwooding
added
docs
joshwooding
commented
Oct 2, 2020
| -const theme = createMuitheme({palette: { type: 'dark' }}), | ||
| +const theme = createMuitheme({ | ||
| -const theme = createMuiTheme({palette: { type: 'dark' }}), | ||
| +const theme = createMuiTheme({ | ||
| + palette: { type: 'dark', text: { hint: 'rgba(0, 0, 0, 0.38)' } }, |
There was a problem hiding this comment.
Wasn't sure whether to change this from type to mode.
There was a problem hiding this comment.
This should be changed, I think.
There was a problem hiding this comment.
Agree, we could base the diff based the most accurate state of v5. So use mode: dark in both cases. @hubgit do you want to send a pull request? :)
There was a problem hiding this comment.
Ok, I'll send a PR. It seems that this diff is the wrong way round, too, if I'm understanding the changes correctly?
oliviertassinari
changed the title
oliviertassinari
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed these.