Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Improve customization of tree item #22846

Merged
merged 13 commits into from Oct 10, 2020
Merged

[TreeView] Improve customization of tree item #22846

merged 13 commits into from Oct 10, 2020

Conversation

joshwooding
Copy link
Member

Closes #22024

Breaking Changes:

Removes onLabelClick and onIconClick. (PR, #19953) a custom ContentComponent should be used instead.

@joshwooding joshwooding added new feature New feature or request breaking change component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! labels Oct 2, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 3, 2020 •
edited

@material-ui/core: parsed: 0.00% 😍, gzip: -0.09% 😍
@material-ui/lab: parsed: +0.47% , gzip: +0.66%

Details of bundle changes

Generated by 🚫 dangerJS against f0784a4

@github-actions github-actions bot mentioned this pull request Oct 3, 2020
Closed
oliviertassinari
oliviertassinari reviewed Oct 7, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding #22024, I would be in favor of changing the default to match the expectation of the developer that has open the issue. Then, we could wait and see if somebody wants to have a click flip both the expanded and selection state. From what I understand, with the controlled mode, both behavior can be implemented.

Regarding the new customization API. It looks interesting, a mix between a component shell and a full hook.

docs/src/pages/components/tree-view/tree-view.md Show resolved Hide resolved
packages/material-ui-lab/src/TreeItem/TreeItemContent.js Outdated Show resolved Hide resolved
@joshwooding
Copy link
Member Author

Regarding #22024, I would be in favor of changing the default to match the expectation of the developer that has open the issue. Then, we could wait and see if somebody wants to have a click flip both the expanded and selection state. From what I understand, with the controlled mode, both behavior can be implemented.

I think we should tackle this in a separate PR if we do.

@joshwooding joshwooding merged commit 3d949c1 into mui:next Oct 10, 2020
@joshwooding joshwooding deleted the improve-customisation-of-tree-item branch October 10, 2020 18:01
@oliviertassinari oliviertassinari mentioned this pull request Jan 18, 2021
Closed
@mnajdova mnajdova mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
breaking change component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@joshwooding @mui-pr-bot @oliviertassinari