Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid] Clarify document about direction column limitation #22871

Merged
merged 1 commit into from
Oct 5, 2020
Merged

[Grid] Clarify document about direction column limitation #22871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 4 additions & 6 deletions docs/src/pages/components/grid/grid.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,12 +135,10 @@ In practice, you can set the `zeroMinWidth` prop:

### direction: column | column-reverse

Though the `Grid` component has a `direction` prop that allows values of `row`, `row-reverse`, `column`, and `column-reverse`,
there are some features that are not supported within `column` and `column-reverse` containers.
The props which define the number of grids the component will use for a given breakpoint
(`xs`, `sm`, `md`, `lg`, and `xl`) are focused on controlling width
and do **not** have similar effects on height within `column` and `column-reverse` containers.
If used within `column` or `column-reverse` containers, these props may have undesirable effects on the width of the `Grid` elements.
The `xs`, `sm`, `md`, `lg`, and `xl` props are **not supported** within `direction="column"` and `direction="column-reverse"` containers.

They define the number of grids the component will use for a given breakpoint. They are intended to control **width** using `flex-basis` in `row` containers but they will impact height in `column` containers.
If used, these props may have undesirable effects on the height of the `Grid` item elements.

## CSS Grid Layout

Expand Down