[docs] For non-SSR language, internal search fall back to English #22902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
previously requested changes
Oct 6, 2020
There was a problem hiding this comment.
Thanks. I'll let @oliviertassinari take a look at the algolia fix.
|
No bundle size changes comparing d9d60e6...a0018cf |
oliviertassinari
approved these changes
Oct 6, 2020
There was a problem hiding this comment.
Nice!
Getting ja working will be challenging. We don't server-side render the Japanese pages, Algolia can't extract the information.
To solve the problem, we would either need to server-side render all the pages. But I believe we would hit a performance issue (timeout in Netlify) or ask Algolia if it's fine to have https://docsearch.algolia.com/docs/config-file#javascript-rendering (basically, are they OK with paying the infra cost?).
|
@bicstone Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22901
For non-SSR language, internal search fall back to English.
in Japanese (non-SSR)
in Chinese (SSR)
