Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Migrate TabIndicator to react-testing-library #22906

Merged
merged 4 commits into from Oct 7, 2020
Merged

[test] Migrate TabIndicator to react-testing-library #22906

merged 4 commits into from Oct 7, 2020

Conversation

eladmotola
Copy link
Contributor

@eladmotola eladmotola commented Oct 6, 2020 •
edited by oliviertassinari

#22911

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 6, 2020 •
edited

No bundle size changes comparing d9d60e6...5a6394a

Generated by 🚫 dangerJS against 5a6394a

@github-actions github-actions bot mentioned this pull request Oct 6, 2020
Closed
@eladmotola
Copy link
Contributor Author

How can I rerun the ci? I don't think it's related to my changes

@eps1lon
Copy link
Member

eps1lon commented Oct 6, 2020

How can I rerun the ci? I don't think it's related to my changes

CodeCoverage has not been very reliable the past few days. Sorry for the inconvenience. I've re-started the failing task. You can always trigger it manually by pushing changes e.g. git commit --allow-empty -m 'poke CI' && git push

joshwooding
joshwooding previously requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, one minor comment.

packages/material-ui/src/Tabs/TabIndicator.test.js Outdated Show resolved Hide resolved
@oliviertassinari oliviertassinari mentioned this pull request Oct 6, 2020
Closed
46 tasks
@oliviertassinari oliviertassinari changed the title [test] Migrate TabIndicator to testing library [test] Migrate TabIndicator to react-testing-library Oct 6, 2020
@oliviertassinari oliviertassinari mentioned this pull request Oct 6, 2020
Merged
1 task
@eps1lon eps1lon merged commit a1c945e into mui:next Oct 7, 2020
@eps1lon
Copy link
Member

eps1lon commented Oct 7, 2020

@eladmotola Thanks!

@eladmotola eladmotola deleted the refactor/migrate-tabindicator-testing-library branch October 7, 2020 09:14
@oliviertassinari oliviertassinari added the component: tabs This is the name of the generic UI component, not the React module! label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@joshwooding joshwooding joshwooding left review comments

Assignees
No one assigned
Labels
component: tabs This is the name of the generic UI component, not the React module! test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eladmotola @mui-pr-bot @eps1lon @oliviertassinari @joshwooding