[docs] Use demo name as codesandbox name #22926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Oct 7, 2020
| <link rel="stylesheet" href="https://fonts.googleapis.com/icon?family=Material+Icons" /> | ||
| <div id="root"></div> | ||
| </body> | ||
| 'public/index.html': ` |
There was a problem hiding this comment.
See codesandbox/codesandbox-client#4737. Old sandboxes are fine since they only use body. Once we want to use head we need to have it in public/index.html.
Benefit: Now also works when downloaded though we've never heard anyone complain.
|
No bundle size changes comparing d08a755...f991de4 |
oliviertassinari
approved these changes
Oct 7, 2020
|
I'll leave this open till the end of the week in case we get a response to codesandbox/codesandbox-client#4983. |
eps1lon
added
on hold
oliviertassinari
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the demo name in the codesandbox and page title. Also includes the currently used docs language for more accurate repros.
Note that this only works when the sandbox is opened in a new window. The integrated view has a non-descriptive UUID-like title. Possibly due to codesandbox/codesandbox-client#4983.