[Autocomplete] Fix filtering when value is already selected #22935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montelius
changed the title
montelius
changed the title
oliviertassinari
added
bug 🐛
oliviertassinari
force-pushed
the
issue22792
branch
from
f6048ad
to
469e0e4
Compare
oliviertassinari
changed the title
oliviertassinari
approved these changes
Oct 9, 2020
oliviertassinari
force-pushed
the
issue22792
branch
from
469e0e4
to
b19cc20
Compare
|
@montelius I have pushed forward your initial solution. Thanks for demonstrating a working solution! If you see any issue with the revised approach, please let us know, we can work on a follow up pull request. At least, It seems that this first issue solve the reported problem :) |
|
@oliviertassinari I looks great, thanks for taking the time to polish! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #22792.
I've also added three tests, one of which doesn't work correctly (the 'should filter options when new input value matches option' case). Basically, I'm trying to simulate user key input into the textbox, but the key input doesn't seem to change the input text in the textbox. Could I get some help solving this?