[docs] Don't suggest putting a Switch inside a ListItemSecondaryAction #23018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
oliviertassinari
added
component: list
|
Looks good, I think that we could also explain for this test case the tradeoff around |
oliviertassinari
force-pushed
the
patch-1
branch
from
227c614
to
d051b4a
Compare
oliviertassinari
approved these changes
Oct 12, 2020
| @@ -12,7 +12,7 @@ const useStyles = makeStyles((theme: Theme) => | |||
| createStyles({ | |||
| root: { | |||
| width: '100%', | |||
| maxWidth: '36ch', | |||
| maxWidth: 360, | |||
There was a problem hiding this comment.
done to have visual consistency with the other demos
| @@ -9,7 +9,7 @@ const useStyles = makeStyles((theme: Theme) => | |||
| root: { | |||
| width: '100%', | |||
| height: 400, | |||
| maxWidth: 300, | |||
| maxWidth: 360, | |||
There was a problem hiding this comment.
done to have visual consistency with the other demos
| width={360} | ||
| itemSize={46} | ||
| itemCount={200} | ||
| overscanCount={5} |
There was a problem hiding this comment.
Add overscan to limit white areas
|
@sirlantis It's a great first pull request on Material-UI 👌🏻. Thank you for working on it! |
|
@oliviertassinari Thanks, but to be honest, you did the majority of it. So: double thanks. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid future cases like #23013