Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SwipeableDrawer] Decorrelate swipeAreaWidth and initial jumping amount #23042

Merged
merged 4 commits into from Oct 15, 2020
Merged

[SwipeableDrawer] Decorrelate swipeAreaWidth and initial jumping amount #23042

merged 4 commits into from Oct 15, 2020

Conversation

omidtajik
Copy link
Contributor

@omidtajik omidtajik commented Oct 13, 2020 •
edited by oliviertassinari

This PR removes dependency between swipeAreaWidth prop and the ready-for-dragging signal of drawer related to

Closes #23037

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 13, 2020 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against ca0282c

@oliviertassinari oliviertassinari added component: SwipeableDrawer The React component. new feature New feature or request labels Oct 14, 2020
@oliviertassinari oliviertassinari merged commit d241f37 into mui:next Oct 15, 2020
@oliviertassinari
Copy link
Member

@omidtajik It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

@omidtajik
Copy link
Contributor Author

It's my pleasure to contribute in this awesome project ❤️

@omidtajik omidtajik deleted the fix/SwipeableDrawer branch October 15, 2020 19:39
@oliviertassinari oliviertassinari added the component: drawer This is the name of the generic UI component, not the React module! label Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: drawer This is the name of the generic UI component, not the React module! component: SwipeableDrawer The React component. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SwipeableDrawer] Decorrelate swipe area width and the translation to signal that dragging started
3 participants
@omidtajik @mui-pr-bot @oliviertassinari