Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Table] Fix empty row logic when displaying all #23280

Merged
merged 6 commits into from Oct 29, 2020
Merged

[Table] Fix empty row logic when displaying all #23280

merged 6 commits into from Oct 29, 2020

Conversation

JoaoJesus94
Copy link
Contributor

@JoaoJesus94 JoaoJesus94 commented Oct 27, 2020 •
edited by oliviertassinari

Preview: https://deploy-preview-23280--material-ui.netlify.app/components/tables/#custom-pagination-options

Changes

  • Fix text when selecting table all option

Related to #23277
Closes #23282

@JoaoJesus94 JoaoJesus94 changed the title fix table all option on demo display [Table] Fix all option text on demo display Oct 27, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 27, 2020 •
edited

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%

Details of bundle changes

Generated by 🚫 dangerJS against 772b303

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Oct 27, 2020
@github-actions github-actions bot mentioned this pull request Oct 27, 2020
Closed
@oliviertassinari oliviertassinari mentioned this pull request Oct 27, 2020
Closed
2 tasks
@JoaoJesus94
Copy link
Contributor Author

argos is failing but I checked the details and it is something related with BadgeAvatars 😕

eps1lon
eps1lon previously requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. Could you add some tests so that we can verify this actually fixed the underlying issue(s)?

@oliviertassinari oliviertassinari mentioned this pull request Oct 28, 2020
Closed
2 tasks
@oliviertassinari oliviertassinari changed the title [Table] Fix all option text on demo display [Table] Fix empty row logic when displaying all Oct 28, 2020
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 28, 2020 •
edited

@JoaoJesus94 I have updated the pull request to only focus on #23282. For #23277, we will need a different effort per #23277 (comment).

@oliviertassinari oliviertassinari merged commit 70d9d20 into mui:next Oct 29, 2020
@oliviertassinari
Copy link
Member

@JoaoJesus94 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Table] - rows per page not working correctly
4 participants
@JoaoJesus94 @mui-pr-bot @oliviertassinari @eps1lon