Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump next to 10.0.0 #23281

Merged
merged 4 commits into from
Oct 29, 2020
Merged

Bump next to 10.0.0 #23281

merged 4 commits into from
Oct 29, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Oct 27, 2020 •
edited
Loading

Couldn't spot any breaking changes. Interesting parts I could spot are the new i18n routing and their image component.

@eps1lon eps1lon added the docs Improvements or additions to the documentation label Oct 27, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Oct 27, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 172d13c

@github-actions github-actions bot mentioned this pull request Oct 27, 2020
Closed
@oliviertassinari
Copy link
Member

i18n routing

Is there a specific issue we face with i18n that Next.js's built-in API that solves? Would it justify prioritizing work on it? I'm aware of one issue/conflict with the getStaticProp + URL rewrite. Do we have others?

@eps1lon
Copy link
Member Author

eps1lon commented Oct 27, 2020 •
edited by oliviertassinari
Loading

Is there a specific issue we face with i18n that Next.js's built-in API that solves?

  1. bad perf (bigger bundle than needed, too much JS to run)
  2. too much code to maintain that is not needed
  3. /api routes have no client side routing

Would it justify prioritizing work on it?

Over what?

@eps1lon eps1lon marked this pull request as ready for review October 28, 2020 11:15
@eps1lon eps1lon marked this pull request as draft October 28, 2020 11:16
@eps1lon
Copy link
Member Author

eps1lon commented Oct 28, 2020

Looks good with all locales.

@eps1lon eps1lon marked this pull request as ready for review October 28, 2020 15:12
@eps1lon eps1lon merged commit 7475ef6 into mui:next Oct 29, 2020
@eps1lon eps1lon deleted the docs/next-10 branch October 29, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eps1lon @mui-pr-bot @oliviertassinari