Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Fix implicit transitive 'csstype' dependency #23301

Merged
merged 1 commit into from Oct 29, 2020
Merged

[core] Fix implicit transitive 'csstype' dependency #23301

merged 1 commit into from Oct 29, 2020

Conversation

quinnturner
Copy link
Contributor

@quinnturner quinnturner commented Oct 28, 2020 •
edited

Closes #23300

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 28, 2020 •
edited

No bundle size changes

Generated by 🚫 dangerJS against 453c0f9

@oliviertassinari oliviertassinari changed the title fix(core): Add csstype to package.json [core] Fix implicit transitive 'csstype' dependency Oct 28, 2020
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 28, 2020
eps1lon
eps1lon requested changes Oct 28, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we actually depending on csstype? We technically want the same version as react so importing the css types from react instead of csstype might be the better choice. It like just ended up in the bundle accidentally due to auto-import.

eps1lon
eps1lon approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage was introduced in #22435 which inlined the @emotion/styled-base types. Change is fine 👍

@eps1lon eps1lon merged commit e3040c5 into mui:next Oct 29, 2020
@quinnturner quinnturner deleted the patch-1 branch October 29, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implicit transitive 'csstype' dependency
4 participants
@quinnturner @mui-pr-bot @oliviertassinari @eps1lon