Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Make it clearer that custom router is supported #23304

Merged
merged 2 commits into from Oct 29, 2020

Conversation

Maxgit3
Copy link
Contributor

@Maxgit3 Maxgit3 commented Oct 29, 2020

added a list of components with the component prop to the composition.md file
at /docs/src/pages/guides/composition/composition.md

Closes #22001

@mui-pr-bot
Copy link

mui-pr-bot commented Oct 29, 2020

No bundle size changes

Generated by 🚫 dangerJS against 9502140

@Maxgit3
Copy link
Contributor Author

Maxgit3 commented Oct 29, 2020

@oliviertassinari I have created a list in the Markdown file. looks like one of the tests failed. Not sure if that test is appropriate to document file.

@oliviertassinari oliviertassinari changed the title adding list of components with component prop [docs] Make it clearer that custom router is supported everywhere Oct 29, 2020
@oliviertassinari oliviertassinari changed the title [docs] Make it clearer that custom router is supported everywhere [docs] Make it clearer that custom router is supported Oct 29, 2020
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Oct 29, 2020
@oliviertassinari oliviertassinari merged commit 5cc2752 into mui:next Oct 29, 2020
@oliviertassinari
Copy link
Member

@Maxgit3 Thanks for looking into it, I have updated the wording to keep it simpler; I think that the idea should be to communicate that it's a systematic solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BottomNavigation] Link docs
3 participants