[docs] Fix language cookie #23324
Merged
[docs] Fix language cookie #23324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrookes
commented
Oct 30, 2020
| window.location = preferedLanguage === 'en' ? canonical : `/${preferedLanguage}${canonical}`; | ||
| } else if (userLanguageUrl !== userLanguage) { | ||
| } else if (userLanguage !== userLanguageUrl) { | ||
| dispatch({ type: ACTION_TYPES.OPTIONS_CHANGE, payload: { userLanguage: userLanguageUrl } }); | ||
| } |
There was a problem hiding this comment.
Never actually seem to reach this branch, but then not sure where userLanguage is set otherwise?
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to solve the problem of not respecting a visitor's docs language setting on subsequent visits. There's another issue with the browser constantly reloading a 404 page when the browser language is set, but I haven't tried to resolve that here.