[test] Improve test debugging #23372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Nov 2, 2020
| // default | ||
| '.git', | ||
| // node_modules can be nested with workspaces | ||
| '**/node_modules/**', |
There was a problem hiding this comment.
mocha includes 'node_modules' which does not cover nested n_m. Nested n_m exist when using workspaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticeable in "old" repositories that accumulated a lot of ignored files. I got a 8s bootstrap time reduction in watchmode since it went from watching ~60k files to ~10k files.
--inspect-brktoyarn tWorks exactly like
node --inspect-brkbut by adding the flag to our CLI we can control where the debugger should start.node --inspect-brk test/cli.jswould not debug the tests.