Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack-example build error. #2344

Merged
merged 2 commits into from
Dec 2, 2015
Merged

Conversation

hitripod
Copy link
Contributor

@hitripod hitripod commented Dec 2, 2015

Fix webpack-example build error.

5:14   error  Unable to require module with extension '.jsx'
16:18  error  Unexpected space before function parentheses
44:8   error  There should be no space after '{'
44:22  error  There should be no space before '}'

5:14   error  Unable to require module with extension '.jsx'
16:18  error  Unexpected space before function parentheses
44:8   error  There should be no space after '{'
44:22  error  There should be no space before '}'
@oliviertassinari
Copy link
Member

@hitripod Thanks for raising the issue. This on is one me.
I see two options to fix the issue.
Option 1, add "root": true, to the .eslintrc and leave the source code untouched
Option 2, leave the .eslintrc untouched and fix the source code.

Could you choose one of those option?
Thanks

I suspect the other example to have the same issue.

@oliviertassinari
Copy link
Member

@hitripod Thanks!

oliviertassinari added a commit that referenced this pull request Dec 2, 2015
Fix webpack-example build error.
@oliviertassinari oliviertassinari merged commit 1200b3f into mui:master Dec 2, 2015
@oliviertassinari
Copy link
Member

Warning: show has been deprecated in favor of explicitly setting the open property

Oups, we should fix this 😬

@hitripod
Copy link
Contributor Author

hitripod commented Dec 2, 2015

Thanks for so quick reply, I choose the option 2. Another one commit is pushed.

BTW, I've tested browserify-gulp-example. It is fine.

@oliviertassinari
Copy link
Member

Ok nice, #2345 should fix the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Relating to /examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants