Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Replace emotion-server packages with @emotion/server #23557

Merged
merged 5 commits into from Nov 16, 2020
Merged

[docs] Replace emotion-server packages with @emotion/server #23557

merged 5 commits into from Nov 16, 2020

Conversation

numToStr
Copy link
Contributor

@numToStr numToStr commented Nov 15, 2020 •
edited

In emotion-v11, create-emotion-server is replaced by @emotion/server/create-instance.

PS: Documentation still uses create-emotion-server v10. I am working on replacing the same. Done

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 15, 2020 •
edited

No bundle size changes

Generated by 🚫 dangerJS against d583871

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Nov 15, 2020
@github-actions github-actions bot mentioned this pull request Nov 15, 2020
Closed
@numToStr numToStr changed the title [examples] Replace create-emotion-server with @emotion/server/create-instance Replace create-emotion-server with @emotion/server/create-instance Nov 15, 2020
@oliviertassinari oliviertassinari changed the title Replace create-emotion-server with @emotion/server/create-instance [examples] Replace create-emotion-server with @emotion/server/create-instance Nov 15, 2020
@oliviertassinari oliviertassinari changed the title [examples] Replace create-emotion-server with @emotion/server/create-instance [docs] Replace create-emotion-server with @emotion/server/create-instance Nov 15, 2020
@eps1lon eps1lon changed the title [docs] Replace create-emotion-server with @emotion/server/create-instance [docs] Replace emotion-server packages with @emotion/server Nov 16, 2020
eps1lon
eps1lon approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. updated lockfile
  2. reverted changes to translated files
  3. applied same change to emotion-server
    Now we should have complete the emotion 11 update

@oliviertassinari oliviertassinari added the package: styled-engine Specific to @mui/styled-engine label Nov 16, 2020
@eps1lon eps1lon merged commit 2ee845a into mui:next Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@eps1lon eps1lon eps1lon approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: styled-engine Specific to @mui/styled-engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@numToStr @mui-pr-bot @oliviertassinari @eps1lon