Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DatePicker] Add missing TypeScript definitions #23560

Merged
merged 1 commit into from Nov 15, 2020
Merged

[DatePicker] Add missing TypeScript definitions #23560

merged 1 commit into from Nov 15, 2020

Conversation

mbrookes
Copy link
Member

Closes #23559

@mbrookes mbrookes added the package: lab Specific to @mui/lab label Nov 15, 2020
@mui mui deleted a comment from mui-pr-bot Nov 15, 2020
@mui-pr-bot
Copy link

No bundle size changes

Generated by 🚫 dangerJS against dc7f26e

@github-actions github-actions bot mentioned this pull request Nov 15, 2020
Closed
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 15, 2020 •
edited

It doesn't seem to be enough but I don't understand why: https://codesandbox.io/s/basicdatepicker-material-demo-forked-l72my?file=/demo.tsx.

oliviertassinari
oliviertassinari approved these changes Nov 15, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work typescript labels Nov 15, 2020
@mbrookes mbrookes merged commit 3025734 into mui:next Nov 15, 2020
@mbrookes mbrookes deleted the build-types branch November 15, 2020 23:25
@numToStr numToStr mentioned this pull request Nov 16, 2020
Closed
@oliviertassinari oliviertassinari changed the title [lab] Fix build [DatePicker] Add missing TypeScript definitions Nov 22, 2020
@oliviertassinari oliviertassinari removed the package: lab Specific to @mui/lab label Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lab] TypeScript types missing
3 participants
@mbrookes @mui-pr-bot @oliviertassinari