Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] Add missing exports #23621

Merged
merged 10 commits into from Nov 20, 2020
Merged

Conversation

havgry
Copy link
Contributor

@havgry havgry commented Nov 19, 2020

As agreed up in #23608, I've adding missing exports and cleaned up the index files a bit.

I've broken my changes up into quite a few commits to make it as easy as possible to understand what's going on in this PR. I ran into one issue which I'm not sure should be solved in this PR:

../material-ui-lab/src/index.d.ts(35,1): error TS2308: Module './DateRangePicker' has already exported a member named 'DateRange'. Consider explicitly re-exporting to resolve the ambiguity.
../material-ui-lab/src/index.d.ts(53,1): error TS2308: Module './DateRangePicker' has already exported a member named 'DateRange'. Consider explicitly re-exporting to resolve the ambiguity.
../material-ui-lab/src/index.d.ts(95,1): error TS2308: Module './DateRangePicker' has already exported a member named 'DateRange'. Consider explicitly re-exporting to resolve the ambiguity.
../material-ui-lab/src/index.d.ts(116,1): error TS2308: Module './PickersCalendarSkeleton' has already exported a member named 'styles'. Consider explicitly re-exporting to resolve the ambiguity.

Closes #23608

@mui-pr-bot
Copy link

mui-pr-bot commented Nov 19, 2020

@material-ui/lab: parsed: +0.23% , gzip: +0.75%

Details of bundle changes

Generated by 🚫 dangerJS against 65a0e8b

@oliviertassinari oliviertassinari added component: date picker This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Nov 19, 2020
@oliviertassinari oliviertassinari changed the title [Lab] Add missing exports [DatePicker] Add missing exports Nov 19, 2020
@oliviertassinari oliviertassinari merged commit d76aadf into mui:next Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: date picker This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DatePicker] Missing exports in lab/index.js
4 participants