fix warning on dialog

[chrismcv]

No description provided.

[oliviertassinari]

This is breaking one test. What's is your warning?

[chrismcv]

missing key on actionObjects

[chrismcv]

argh - typo - fixed React.Children not React.children

[oliviertassinari]

React.Children.toArray
Return the children opaque data structure as a flat array with keys assigned to each child. Useful if you want to manipulate collections of children in your render methods, especially if you want to reorder or slice this.props.children before passing it down.

If we follow this page, I think that we can remove the key affectation from _getAction().
Another way to do is by adding key to ValidElement with cloneElement

What's best?

[chrismcv]

I think removing the key is cleanest

[oliviertassinari]

I'm ok with this. Could you squash down the commits?
I will merge, unless @subjectix has any feedbacks, thanks!

[chrismcv]

@oliviertassinari squished

[alitaheri]

@oliviertassinari Actually, I believe all usage of JSON must be replaced with composing. But that's for later on. For now this is good. Nice work @chrismcv 👍

[oliviertassinari]

@chrismcv Thanks