[docs] Add settings panel to allow system mode #23722
Conversation
There was a problem hiding this comment.
Nice :)! A few changes I would suggest:
- Make the "settings" button icon available on all the pages
- "Site settings" -> "Settings" for brevity.
- Have you considered making the side panel wider, like 400px with a horizontal toggle button? (both for theme mode and text direction)
- It's typically for cases like this that a designer could come in and improve the design (I personally don't know how to improve it, maybe it's as good as it could get 🤷♂️).
Odd. What's preventing it?
Yep. It looks worse IMHO, but happy to review a suggested change.
Yes, the default color scheme for the toggle buttons doesn't work so well with text. I didn't try to fix it. |
Hmm, no, I'm seeing the same. |
| if (process.browser) { | ||
| const value = `; ${document.cookie}`; | ||
| const parts = value.split(`; ${name}=`); | ||
| if (parts.length === 2) return parts.pop().split(';').shift(); |
There was a problem hiding this comment.
That poor array is getting torn apart before it could live for some time 😆
@mbrookes Right, it's not the cache. |
|
Bug, it should behave like a radio:
We shouldn't be able to unselect the active value by clicking on it. |
…erial-ui into docs-settings-panel
|
I have horizontal looking decent:
Better? |
|
I like how it leaves space to add more content later on. |
mbrookes
force-pushed
the
docs-settings-panel
branch
from
0a95e68
to
346113d
Compare
|
Is this live already? I'm not seeing it. |
|
It's live, yes: https://next.material-ui.com/. |
This has been on my list of things to do for longer than I care to remember. 😄
Closes #23683