Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Select] Fixing typescript not recognizing the 'component' property on the 'MenuListProps' #23876

Closed

Conversation

domodevelopment
Copy link

@domodevelopment domodevelopment commented Dec 7, 2020

(This builds off of discussion in #17646)

Fixes #17579.

These changes try and follow a similar pattern for the CardHeader in #20179. Guidance on how I should write more robust tests for this would be appreciated as well as if this is even going in the right direction in the first place :-)

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 7, 2020

No bundle size changes

Generated by 🚫 dangerJS against e8314cc

@domodevelopment domodevelopment marked this pull request as draft December 7, 2020 03:34
@domodevelopment domodevelopment changed the title [Typescript] Fixing typescript not recognizing the 'component' property on the 'MenuListProps' [Select] Fixing typescript not recognizing the 'component' property on the 'MenuListProps' Dec 7, 2020
@oliviertassinari
Copy link
Member

@domodevelopment Did you have progress with this problem?

@domodevelopment
Copy link
Author

@domodevelopment Did you have progress with this problem?

@oliviertassinari I haven't been able to make more progress since last weekend, but today I'll get the tests passing and move this out of draft

@vercel
Copy link

vercel bot commented Dec 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mui-org/material-ui/4nn1faq9p
✅ Preview: https://material-ui-git-typescript-menu-list-props.mui-org.vercel.app

@domodevelopment
Copy link
Author

Hmm. @oliviertassinari if there's a chance you can help me with what's going on in yarn typescript, that would be appreciated. onKeyDown is being removed from MenuList.js which is leading to this eslint error:

'onKeyDown' is missing in props validation

I'm having some difficulty understanding why that might be the case or what my changes would've caused for it to get removed. Any thoughts?

https://app.circleci.com/pipelines/github/mui-org/material-ui/29394/workflows/b626eafb-99b7-48ea-a840-2d68cd17c7c4/jobs/203830

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 13, 2020

@domodevelopment I barely know this part of the codebase. @eps1lon Is more familiar with it.

@oliviertassinari
Copy link
Member

I'm closing as the effort has been stale for some time, thanks for the exploration.

@zannager zannager added the component: select This is the name of the generic UI component, not the React module! label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: select This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] MenuListProps missing property 'component'
5 participants