[docs] Update customization/components and customization/global pages #24016

mnajdova · 2020-12-14T18:53:57Z

This PR updates the customization/global and customization/components pages.

mui-pr-bot · 2020-12-14T18:56:41Z

Generated by 🚫 dangerJS against d3728f9

oliviertassinari

A beginning of a review. While we are working on covering the different customization options. I think we could have something on how to identify which element to customize, e.g. with the devtools, then how to cover it into a working override.

On a different note. It feels like /customization/globals/ should actually be /customization/components/ as it covers theme.components. It also feels like https://next.material-ui.com/customization/components/#5-global-theme-variation and https://next.material-ui.com/customization/globals/ covers the same thing.

docs/src/pages/customization/components/SxProp.tsx

docs/src/pages/customization/components/components.md

docs/src/pages/customization/components/DynamicClassName.js

docs/src/pages/customization/components/components.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

…a/material-ui into feat/customization-guide

mnajdova · 2020-12-15T14:04:31Z

packages/material-ui-system/src/index.d.ts

@@ -282,7 +282,7 @@ export interface CSSProperties
 /**
 * Map of all CSS pseudo selectors (`:hover`, `:focus`, ...).
 */
-export type CSSPseudoSelectorProps = { [K in CSS.Pseudos]?: SystemStyleObject };
+export type CSSPseudoSelectorProps<Theme extends object = {}> = { [K in CSS.Pseudos]?: SystemStyleObject<Theme> };


Extract these changes to different PR.

mnajdova · 2020-12-15T14:42:53Z

While we are working on covering the different customization options. I think we could have something on how to identify which element to customize, e.g. with the devtools, then how to cover it into a working override.

Let me revert and extend the Using the dev tools section, as proposed in #24016 (comment)

On a different note. It feels like /customization/globals/ should actually be /customization/components/ as it covers theme.components. It also feels like https://next.material-ui.com/customization/components/#5-global-theme-variation and https://next.material-ui.com/customization/globals/ covers the same thing.

Maybe we can just extend the https://next.material-ui.com/customization/globals/ to contain the stylesOverrides and variants options from the theme.components and just link these under the last point of global theme variation.

Co-authored-by: Matt <github@nospam.33m.co>

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Co-authored-by: Matt <github@nospam.33m.co>

docs/src/pages/customization/components/components.md

stunaz · 2020-12-24T15:15:04Z

@mnajdova does this work for all components or only migrated components? it doesnt seem to work with Divider for example... see https://codesandbox.io/s/sxprop-material-demo-forked-wdfhz?file=/demo.tsx

mnajdova · 2020-12-24T16:30:06Z

@mnajdova does this work for all components or only migrated components? it doesnt seem to work with Divider for example... see https://codesandbox.io/s/sxprop-material-demo-forked-wdfhz?file=/demo.tsx

@stunaz it works only on the migrated components

init

0620241

mnajdova requested a review from oliviertassinari December 14, 2020 18:56

oliviertassinari added the docs Improvements or additions to the documentation label Dec 14, 2020

oliviertassinari reviewed Dec 14, 2020

View reviewed changes

mnajdova and others added 13 commits December 15, 2020 13:03

Update docs/src/pages/customization/components/components.md

faa4968

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/components/components.md

0802f6f

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

comments

1cd763b

Update docs/src/pages/customization/components/components.md

e26d5fc

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/components/components.md

804b7b8

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/components/components.md

db340c3

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/components/components.md

7debdc6

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/components/components.md

90fbb93

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/components/components.md

8ae5117

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/components/components.md

8345fd7

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

comments

ccf3987

Merge branch 'feat/customization-guide' of https://github.com/mnajdov…

f9b659c

…a/material-ui into feat/customization-guide

selectors

d054f77

github-actions bot mentioned this pull request Dec 15, 2020

Update snapshots for pr/24016 eps1lon/mui-scripts-incubator#1532

Closed

mnajdova added 2 commits December 15, 2020 13:47

fixes and improvements

d3596e6

fixed ts & lint issues

71e4f99

mnajdova commented Dec 15, 2020

View reviewed changes

ts errors

86d8f9f

mnajdova added 4 commits December 15, 2020 15:45

removed inline style

936457e

comments

c2d7fee

typo

43d07e1

comments

f69ffc7

mnajdova requested a review from oliviertassinari December 15, 2020 15:51

mnajdova marked this pull request as ready for review December 15, 2020 16:08

mnajdova and others added 20 commits December 19, 2020 09:28

Update docs/src/pages/customization/components/components.md

89f2317

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

22038fa

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

078d265

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

9b565d2

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

47c011b

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

4a77f65

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

cdf75cf

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

fd18738

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

65a8993

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

1ef15ac

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

ada281f

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

b638090

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

00a83da

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

00b308b

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/components/components.md

e685e90

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/globals/globals.md

db7d8a2

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/globals/globals.md

890b272

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

Update docs/src/pages/customization/globals/globals.md

2a1fe69

Co-authored-by: Matt <github@nospam.33m.co>

Update docs/src/pages/customization/globals/globals.md

ed71d39

Co-authored-by: Matt <github@nospam.33m.co>

comments

7020e7a

mnajdova requested a review from mbrookes December 19, 2020 09:19

mbrookes reviewed Dec 19, 2020

View reviewed changes

docs/src/pages/customization/components/components.md Outdated Show resolved Hide resolved

Update docs/src/pages/customization/components/components.md

d3728f9

mbrookes approved these changes Dec 19, 2020

View reviewed changes

mnajdova merged commit 82a2c5c into mui:next Dec 20, 2020

This was referenced Dec 21, 2020

[docs] Rename customization/components to customization/how-to-customize #24089

Merged

[docs] Rename "Customization > Theme > Global" to "Customization > Theme > Components" #24115

Merged

mnajdova mentioned this pull request Dec 29, 2020

[docs] Improve naming and structure of the Customization and Guide pages #24175

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[docs] Update customization/components and customization/global pages #24016

[docs] Update customization/components and customization/global pages #24016

mnajdova commented Dec 14, 2020 •

edited

mui-pr-bot commented Dec 14, 2020 •

edited

oliviertassinari left a comment

mnajdova Dec 15, 2020

mnajdova commented Dec 15, 2020

stunaz commented Dec 24, 2020

mnajdova commented Dec 24, 2020

[docs] Update customization/components and customization/global pages #24016

[docs] Update customization/components and customization/global pages #24016

Conversation

mnajdova commented Dec 14, 2020 • edited

mui-pr-bot commented Dec 14, 2020 • edited

oliviertassinari left a comment

Choose a reason for hiding this comment

mnajdova Dec 15, 2020

Choose a reason for hiding this comment

mnajdova commented Dec 15, 2020

stunaz commented Dec 24, 2020

mnajdova commented Dec 24, 2020

mnajdova commented Dec 14, 2020 •

edited

mui-pr-bot commented Dec 14, 2020 •

edited