Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Badge] Fix the classes description to reflect the correct component #24035

Merged
merged 2 commits into from Dec 18, 2020
Merged

[Badge] Fix the classes description to reflect the correct component #24035

merged 2 commits into from Dec 18, 2020

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Dec 17, 2020 •
edited

All classes are applied to the badge not root.

@mnajdova
Copy link
Member Author

We could do these changes to master as well...

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 17, 2020 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against ba93f06

oliviertassinari
oliviertassinari reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do these changes to master as well...

I believe "styles" is OK with v4, it's only starting with v5 that we do no longer use these class names to apply the styles.

@github-actions github-actions bot mentioned this pull request Dec 17, 2020
Closed
@mnajdova
Copy link
Member Author

I believe "styles" is OK with v4, it's only starting with v5 that we do no longer use these class names to apply the styles.

I meant the changes regarding the wrong slot root -> badge

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation component: badge This is the name of the generic UI component, not the React module! labels Dec 17, 2020
@oliviertassinari oliviertassinari changed the title [Badge] Fix the classes description to reflect the correct component they are being applied to [Badge] Fix the classes description to reflect the correct component Dec 17, 2020
@mnajdova mnajdova merged commit 1fff5d2 into mui:next Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: badge This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mnajdova @mui-pr-bot @oliviertassinari