Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Animate component's mounting and unmounting #24049

Merged
merged 8 commits into from Dec 20, 2020
Merged

[docs] Animate component's mounting and unmounting #24049

merged 8 commits into from Dec 20, 2020

Conversation

cjoecker
Copy link
Contributor

@cjoecker cjoecker commented Dec 19, 2020 •
edited by mbrookes

@cjoecker
Copy link
Contributor Author

This is a PR for this issue:
#24042

@github-actions github-actions bot mentioned this pull request Dec 19, 2020
Closed
@mui mui deleted a comment from mui-pr-bot Dec 19, 2020
@mbrookes
Copy link
Member

mbrookes commented Dec 19, 2020 •
edited

@cjoecker Thanks for working on it!

Looks good so far. Could it perhaps be simplified a bit by adding items from a list, and removing the text field? On the flip side, I'm wondering if we should perhaps use a List and ListItems for a closer-to-real-world example?

@mbrookes mbrookes added component: transitions This is the name of the generic UI component, not the React module! new feature New feature or request labels Dec 19, 2020
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 19, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 20, 2020 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against f003aef

@cjoecker
Copy link
Contributor Author

@mbrookes Done :)

mbrookes
mbrookes approved these changes Dec 20, 2020
View reviewed changes
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@oliviertassinari
Copy link
Member

I have tried to polish the new section:

Capture d’écran 2020-12-20 à 23 39 22

@mbrookes mbrookes merged commit 9eba24e into mui:next Dec 20, 2020
@mbrookes
Copy link
Member

@cjoecker Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes approved these changes

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
component: transitions This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Transition] Document the grouping feature
4 participants
@cjoecker @mbrookes @mui-pr-bot @oliviertassinari