New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doc] Convert Avatar to use the new standard #2407
[Doc] Convert Avatar to use the new standard #2407
Conversation
Looks good to me. So happy with where the docs are going ^_^ |
children: React.PropTypes.node, | ||
|
||
/** | ||
* The icon or letter color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The icon or the letter's color.
@oliviertassinari If you be so kind, let's address #2310 while we are migrating the docs. Add a className to Avatar while you're at it 😁. Like I did with #2415 |
/** | ||
* The css class name of the root `div` element. | ||
*/ | ||
className: React.PropTypes.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind this, but I think it helps readability to be more explicit. If you agree please add className to props destructuring and to the div's props.
after that do a rebase and merge. 👍 👍 👍 |
[Doc] Convert Avatar to use the new standard
🎉 👍 |
This is following #2382.
We now have to convert every doc component. That's pretty straightforward.
This has several advantages: