[lab] Drop usage of createStyles #24158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
bug 🐛
eps1lon
force-pushed
the
fix/lab/inlined-types
branch
2 times, most recently
from
d8d40f9
to
d0d5637
Compare
eps1lon
changed the title
oliviertassinari
approved these changes
Dec 30, 2020
eps1lon
force-pushed
the
fix/lab/inlined-types
branch
from
8bd5543
to
68dee8d
Compare
|
Want to get #24188 in first before we rebase and merge this PR. |
github-actions
bot
added
the
PR: out-of-date
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
eps1lon
force-pushed
the
fix/lab/inlined-types
branch
from
dfb5c3b
to
3131868
Compare
github-actions
bot
removed
the
PR: out-of-date
|
The inline styles declaration is huge and not really what we want. |
- not docoumented - not tested - not typed in /core
eps1lon
force-pushed
the
fix/lab/inlined-types
branch
from
cd82a1d
to
250e8fa
Compare
eps1lon
force-pushed
the
fix/lab/inlined-types
branch
from
250e8fa
to
8923918
Compare
eps1lon
commented
Jan 3, 2021
eps1lon
commented
Jan 3, 2021
| | 'pmButton' | ||
| | 'meridiemButtonSelected'; | ||
|
|
||
| export const styles: MuiStyles<ClockClassKey> = (theme): StyleRules<ClockClassKey> => ({ |
There was a problem hiding this comment.
This might seem like duplication but leads to better locations of type errors of classes or not implemented or not declared (compared to only using MuiStyles; just using Theme => StyleRules would not allow us to switch back to theme-less styles).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #24132
Fixing symptoms of microsoft/TypeScript#42155
Should be reviewed while whitespace changes are hidden.
createStyles(proof of concept: https://app.circleci.com/pipelines/github/mui-org/material-ui/30857/workflows/a296b04d-92ac-4037-b22f-6c67b1667390/jobs/207735)MuiStyles+StyleRulesfor best autocomplete + error locations)Diff of fixed inlined types (expires in 24h): https://www.diffchecker.com/SvdD2VuZ
Diff of generated declaration files: https://app.circleci.com/pipelines/github/mui-org/material-ui/31365/workflows/15c5b765-fa4b-4ff9-9ab5-c92f01c7cd60/jobs/209329/parallel-runs/0/steps/0-110
Part of #24112
Closes #24132
Will dropHaving worked with styles and types a bit more:createStylesin a future PR for visibility. See #20012 (comment)createStylesis super helpful with regards to autocomplete. Will not drop.