[core] Batch small changes #24224
Merged
[core] Batch small changes #24224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
the
umbrella
mnajdova
approved these changes
Jan 2, 2021
eps1lon
reviewed
Jan 2, 2021
| @@ -3,13 +3,14 @@ | |||
| "version": "5.0.0-alpha.21", | |||
| "private": false, | |||
| "author": "Material-UI Team", | |||
| "description": "Material-UI Unstyled - collection of unstyled React components.", | |||
| "description": "Accessible unstyled React components.", | |||
There was a problem hiding this comment.
Can we remove this? The term is used inflationary and lost its meaning a while ago. Instead of contributing to making it meaningless we can be confident enough to omit it.
There was a problem hiding this comment.
"this": Are you referring to "Accessible"?
Suggested change
| "description": "Accessible unstyled React components.", | |
| "description": "Unstyled React components to build custom design systems on top of.", |
|
Can we remove the emotion packages from the dependencies in the |
👍 removed |
|
It seems that including the change of the package.json descriptions was too ambitious for a batch, I'm removing it. Best to move it to a standalone PR. I would expect little or no discussions required for a "batch". |
This reverts commit f903fdc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polish the description of each package f903fdc: I have noticed that we were using the former description, that we never updated it:https://www.npmjs.com/search?q=material%20ui
nextfromlatest.