Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing grid spacing issue #24299

Closed
wants to merge 8 commits into from
Closed

Fixing grid spacing issue #24299

wants to merge 8 commits into from

Conversation

greguintow
Copy link
Contributor

Fixes this issue #24272

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 6, 2021 •
edited
Loading

@material-ui/core: parsed: +0.22% , gzip: +0.21%
@material-ui/lab: parsed: +0.23% , gzip: +0.26%

Details of bundle changes

Generated by 🚫 dangerJS against aa5377d

mbrookes
mbrookes requested changes Jan 9, 2021
View reviewed changes
packages/material-ui/src/Grid/Grid.d.ts Outdated Show resolved Hide resolved
packages/material-ui/src/Grid/Grid.js Outdated Show resolved Hide resolved
@github-actions github-actions bot mentioned this pull request Jan 9, 2021
Closed
@greguintow
Copy link
Contributor Author

Please check out the Demo. The other solution there is on the code is from a user that was discussing issue #24272

@greguintow
Copy link
Contributor Author

This last commit was a code that I wrote a long time ago, but when I got the fork was with an old version of the code.

@greguintow greguintow mentioned this pull request Jan 9, 2021
Merged
1 task
@greguintow
Copy link
Contributor Author

I've created a new PR #24332 to do the same functionally as this without the fullWidth prop

@oliviertassinari
Copy link
Member

Closing for #24332

@zannager zannager added the component: Grid The React component. label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrookes mbrookes mbrookes requested changes

Assignees
No one assigned
Labels
component: Grid The React component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@greguintow @mui-pr-bot @oliviertassinari @mbrookes @zannager