Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Skip expensive GitHub actions on l10nbot commits #24303

Merged
merged 2 commits into from Jan 7, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 7, 2021

Ported behavior of azure pipelines and CircleCI to GitHub actions. Now I just need to cancel ~1300 jobs in the queue 馃槵

Update:
Cancelling queued runs of l10nbot with https://gist.github.com/eps1lon/9c822429bffb5db5a3f221dd00fea842#file-cancel-gh-actions-js

@eps1lon eps1lon added the test label Jan 7, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 7, 2021

No bundle size changes

Generated by 馃毇 dangerJS against 7d613bf

@oliviertassinari
Copy link
Member

On a related note, does GitHub Actions offer a more generous free tier than CircleCI?

Capture d鈥檈虂cran 2021-01-07 a虁 11 00 09

https://docs.github.com/en/free-pro-team@latest/actions/reference/usage-limits-billing-and-administration#usage-limits

@eps1lon
Copy link
Member Author

eps1lon commented Jan 7, 2021

On a related note, does GitHub Actions offer a more generous free tier than CircleCI?

Isn't that more generous than CircleCI? CircleCI has 4 or 5 while GH Actions has 20 (macOS is understandably smaller since they're more expensive).

@oliviertassinari
Copy link
Member

Isn't that more generous than CircleCI?

I was wondering from a CI duration perspective. I don't know the CPU & Memory resources available in each GitHub actions compared to CircleCI.

@eps1lon
Copy link
Member Author

eps1lon commented Jan 7, 2021

Isn't that more generous than CircleCI?

I was wondering from a CI duration perspective. I don't know the CPU & Memory resources available in each GitHub actions compared to CircleCI.

They seemed pretty fast to me. Right now they don't even need to.

@eps1lon eps1lon changed the title [test] Skip dev CI on l10nbot commits [test] Skip expensive GitHub actions on l10nbot commits Jan 7, 2021
@eps1lon
Copy link
Member Author

eps1lon commented Jan 7, 2021

Queue has settled again and with GH actions running on this PR I consider it verified that the implementation works as expected.

Note how we just had to cancel the 1300 expensive tasks to get the queue of 3300 tasks cleared. The number of runs is clearly not the problem.

@eps1lon eps1lon merged commit af43284 into mui:next Jan 7, 2021
@eps1lon eps1lon deleted the test/l10nbot-ci branch January 7, 2021 11:02
@eps1lon
Copy link
Member Author

eps1lon commented Jan 13, 2021

Queue has settled again and with GH actions running on this PR I consider it verified that the implementation works as expected.

Well, it verified that they're still runing. Unfortunately, they're also still runing for l10nbot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants