[test] Compensate for Circle CI's low performance #24358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
test-timeout
branch
from
7d1bd2e
to
3ecbbbc
Compare
mbrookes
changed the title
Do you know why that is? |
@eps1lon I don't know. I couldn't find any lead. |
eps1lon
requested changes
Jan 11, 2021
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
eps1lon
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are motivated by the performance issue Circle CI has had since Friday, test_unit-1 takes 6-7 minutes to run. It's x2 slower than usual. This leads to our slower tests to timeout 50% of the time.
Under normal conditions, the test in my env runs in 1min and in the CI, in about 2-3 minutes, hence the factor of x3. From what I recall, I don't have the faster machine in the team, I hope the 1s as the max timeout is enough for everybody. We might need to adjust it.
I have used this opportunity to remove the usage of a
setTimeout(500ms)in a test case.