[core] Update classes generation logic #24371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: -0.08% 😍, gzip: -0.05% 😍 |
mnajdova
commented
Jan 12, 2021
packages/material-ui-unstyled/src/BadgeUnstyled/BadgeUnstyled.js
Outdated
Show resolved
Hide resolved
mnajdova
changed the title
mnajdova
changed the title
packages/material-ui-unstyled/src/composeClasses/composeClasses.d.ts
Outdated
Show resolved
Hide resolved
packages/material-ui-unstyled/src/composeClasses/composeClasses.js
Outdated
Show resolved
Hide resolved
…s.d.ts Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
mnajdova
commented
Jan 12, 2021
packages/material-ui-unstyled/src/composeClasses/composeClasses.js
Outdated
Show resolved
Hide resolved
oliviertassinari
approved these changes
Jan 12, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates how the classes for the components are being generated. It is inspired by #24250 (comment)
There is one common
composeClassesutility introduced that takes care of adding utility classes as well as classes overrides.It should avoid issues like #24250 to ever happen.