Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system] Fix handling of null-ish values #24527

Merged
merged 2 commits into from Jan 21, 2021
Merged

[system] Fix handling of null-ish values #24527

merged 2 commits into from Jan 21, 2021

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jan 21, 2021 •
edited

Closes #24519. It's targetting master because it fixes an issue with a third-party dependency we have no control over: Chrome and it throws an exception. I will apply it to next too afterward.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work package: system Specific to @mui/system component: Box The React component. labels Jan 21, 2021
eps1lon
eps1lon approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliviertassinari oliviertassinari mentioned this pull request Jan 21, 2021
Closed
2 tasks
@mui-pr-bot
Copy link

mui-pr-bot commented Jan 21, 2021 •
edited

Details of bundle changes.

Comparing: 4295444...52f6592

Details of page changes
bundle Size Change Size Gzip Change Gzip
/components/pagination ▲ +10 B (+0.12% ) 8.32 kB -- -1 B
/premium-themes/onepirate/sign-up ▼ -10 B (-0.88% ) 1.12 kB -- -1 B
docs:chunk:shared ▲ +10 B (+0.02% ) 64.1 kB -- -1 B
/_app -- 36.9 kB -- -1 B
/api-docs/accordion-actions -- 1.48 kB -- -1 B
/api-docs/accordion-details -- 1.4 kB -- -1 B
/api-docs/accordion-summary -- 1.7 kB -- -1 B
/api-docs/accordion -- 1.97 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.62 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.88 kB -- -1 B
/api-docs/backdrop -- 1.73 kB -- -1 B
/api-docs/badge -- 2.13 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.79 kB -- -1 B
/api-docs/button-base -- 2.22 kB -- -1 B
/api-docs/button-group -- 2.22 kB -- -1 B
/api-docs/button -- 2.53 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.09 kB -- -1 B
/api-docs/click-away-listener -- 1.45 kB -- -1 B
/api-docs/collapse -- 2.13 kB -- -1 B
/api-docs/container -- 1.83 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.74 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/expansion-panel-actions -- 1.55 kB -- -1 B
/api-docs/expansion-panel-details -- 1.47 kB -- -1 B
/api-docs/expansion-panel-summary -- 1.84 kB -- -1 B
/api-docs/expansion-panel -- 2.04 kB -- -1 B
/api-docs/fab -- 2.1 kB -- -1 B
/api-docs/fade -- 1.5 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.99 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.8 kB -- -1 B
/api-docs/grid-list-tile -- 1.73 kB -- -1 B
/api-docs/grid-list -- 1.63 kB -- -1 B
/api-docs/grid -- 2.56 kB -- -1 B
/api-docs/grow -- 1.55 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.07 kB -- -1 B
/api-docs/icon -- 1.78 kB -- -1 B
/api-docs/input-adornment -- 1.95 kB -- -1 B
/api-docs/input-base -- 2.95 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.94 kB -- -1 B
/api-docs/list-item-avatar -- 1.51 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.75 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/menu -- 2.42 kB -- -1 B
/api-docs/mobile-stepper -- 1.94 kB -- -1 B
/api-docs/modal -- 2.43 kB -- -1 B
/api-docs/native-select -- 2.11 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/outlined-input -- 2.98 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.23 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popover -- 2.7 kB -- -1 B
/api-docs/popper -- 1.92 kB -- -1 B
/api-docs/portal -- 1.34 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.42 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.96 kB -- -1 B
/api-docs/skeleton -- 1.87 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.71 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.32 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.26 kB -- -1 B
/api-docs/swipeable-drawer -- 2.01 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-context -- 1.08 kB -- -1 B
/api-docs/tab-list -- 1.09 kB -- -1 B
/api-docs/tab-panel -- 1.48 kB -- -1 B
/api-docs/tab-scroll-button -- 1.62 kB -- -1 B
/api-docs/tab -- 1.97 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.13 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.47 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.7 kB -- -1 B
/api-docs/tabs -- 2.68 kB -- -1 B
/api-docs/text-field -- 3.18 kB -- -1 B
/api-docs/textarea-autosize -- 1.13 kB -- -1 B
/api-docs/timeline-connector -- 1.4 kB -- -1 B
/api-docs/timeline-content -- 1.43 kB -- -1 B
/api-docs/timeline-dot -- 1.63 kB -- -1 B
/api-docs/timeline-item -- 1.54 kB -- -1 B
/api-docs/timeline-opposite-content -- 1.44 kB -- -1 B
/api-docs/timeline-separator -- 1.4 kB -- -1 B
/api-docs/timeline -- 1.52 kB -- -1 B
/api-docs/toggle-button-group -- 1.92 kB -- -1 B
/api-docs/toggle-button -- 1.79 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.57 kB -- -1 B
/api-docs/tree-item -- 1.89 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/api-docs/unstable-trap-focus -- 1.46 kB -- -1 B
/api-docs/zoom -- 1.52 kB -- -1 B
/blog/2019-developer-survey-results -- 7.59 kB -- -1 B
/blog/2019 -- 5.45 kB -- -1 B
/blog/2020-developer-survey-results -- 9.5 kB -- -1 B
/blog/2020-introducing-sketch -- 4.72 kB -- -1 B
/blog/2020-q1-update -- 5.54 kB -- -1 B
/blog/2020-q2-update -- 5.6 kB -- -1 B
/blog/2020-q3-update -- 7.34 kB -- -1 B
/blog/2020 -- 6.48 kB -- -1 B
/blog/april-2019-update -- 4.33 kB -- -1 B
/blog/august-2019-update -- 3.45 kB -- -1 B
/blog/danail-hadjiatanasov-joining -- 3.4 kB -- -1 B
/blog/december-2019-update -- 3.59 kB -- -1 B
/blog/july-2019-update -- 3.36 kB -- -1 B
/blog/june-2019-update -- 3.23 kB -- -1 B
/blog/march-2019-update -- 3.76 kB -- -1 B
/blog/marija-najdova-joining -- 3.31 kB -- -1 B
/blog/material-ui-v1-is-out -- 7.92 kB -- -1 B
/blog/material-ui-v4-is-out -- 10.9 kB -- -1 B
/blog/may-2019-update -- 3.57 kB -- -1 B
/blog/november-2019-update -- 3.97 kB -- -1 B
/blog/october-2019-update -- 3.72 kB -- -1 B
/blog/september-2019-update -- 3.9 kB -- -1 B
/blog/spotlight-damien-tassone -- 3.29 kB -- -1 B
/company/about -- 1.75 kB -- -1 B
/company/contact -- 1.34 kB -- -1 B
/company/jobs -- 1.33 kB -- -1 B
/company/software-engineer -- 5.34 kB -- -1 B
/components/about-the-lab -- 11.1 kB -- -1 B
/components/accordion -- 22.7 kB -- -1 B
/components/alert -- 14.1 kB -- -1 B
/components/app-bar -- 30.3 kB -- -1 B
/components/autocomplete -- 103 kB -- -1 B
/components/avatars -- 10.1 kB -- -1 B
/components/backdrop -- 3.12 kB -- -1 B
/components/badges -- 15.4 kB -- -1 B
/components/bottom-navigation -- 6.16 kB -- -1 B
/components/box -- 8.34 kB -- -1 B
/components/breadcrumbs -- 14.5 kB -- -1 B
/components/button-group -- 7.99 kB -- -1 B
/components/buttons -- 27.3 kB -- -1 B
/components/cards -- 17.3 kB -- -1 B
/components/checkboxes -- 16.7 kB -- -1 B
/components/chips -- 21.7 kB -- -1 B
/components/click-away-listener -- 5.5 kB -- -1 B
/components/container -- 3.93 kB -- -1 B
/components/css-baseline -- 7.24 kB -- -1 B
/components/dialogs -- 43.2 kB -- -1 B
/components/dividers -- 12.8 kB -- -1 B
/components/drawers -- 31.2 kB -- -1 B
/components/floating-action-button -- 10.9 kB -- -1 B
/components/grid-list -- 11.8 kB -- -1 B
/components/grid -- 32.6 kB -- -1 B
/components/hidden -- 10.3 kB -- -1 B
/components/icons -- 28 kB -- -1 B
/components/links -- 7.35 kB -- -1 B
/components/lists -- 26.2 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 24.3 kB -- -1 B
/components/modal -- 12.5 kB -- -1 B
/components/no-ssr -- 5.5 kB -- -1 B
/components/paper -- 3.38 kB -- -1 B
/components/pickers -- 37.7 kB -- -1 B
/components/popover -- 17.5 kB -- -1 B
/components/popper -- 22.9 kB -- -1 B
/components/portal -- 3.33 kB -- -1 B
/components/progress -- 19.5 kB -- -1 B
/components/radio-buttons -- 15.5 kB -- -1 B
/components/rating -- 10.7 kB -- -1 B
/components/selects -- 32.7 kB -- -1 B
/components/skeleton -- 13.9 kB -- -1 B
/components/slider -- 16.2 kB -- -1 B
/components/snackbars -- 23.2 kB -- -1 B
/components/speed-dial -- 15.3 kB -- -1 B
/components/steppers -- 37.3 kB -- -1 B
/components/switches -- 17.2 kB -- -1 B
/components/tables -- 108 kB -- -1 B
/components/tabs -- 24.9 kB -- -1 B
/components/text-fields -- 56.2 kB -- -1 B
/components/textarea-autosize -- 3.02 kB -- -1 B
/components/timeline -- 7.48 kB -- -1 B
/components/toggle-button -- 11.7 kB -- -1 B
/components/tooltips -- 17.9 kB -- -1 B
/components/transfer-list -- 9.77 kB -- -1 B
/components/transitions -- 12.1 kB -- -1 B
/components/tree-view -- 11.5 kB -- -1 B
/components/typography -- 12.6 kB -- -1 B
/components/use-media-query -- 13.6 kB -- -1 B
/customization/breakpoints -- 17.1 kB -- -1 B
/customization/color -- 19.1 kB -- -1 B
/customization/components -- 37.3 kB -- -1 B
/customization/default-theme -- 8.8 kB -- -1 B
/customization/density -- 10.2 kB -- -1 B
/customization/globals -- 5.12 kB -- -1 B
/customization/palette -- 15.1 kB -- -1 B
/customization/spacing -- 2.87 kB -- -1 B
/customization/theming -- 19.4 kB -- -1 B
/customization/typography -- 13.4 kB -- -1 B
/customization/z-index -- 3.5 kB -- -1 B
/discover-more/backers -- 3.21 kB -- -1 B
/discover-more/changelog -- 1.39 kB -- -1 B
/discover-more/languages -- 3.4 kB -- -1 B
/discover-more/related-projects -- 9.23 kB -- -1 B
/discover-more/roadmap -- 2.9 kB -- -1 B
/discover-more/showcase -- 15.4 kB -- -1 B
/discover-more/team -- 7.25 kB -- -1 B
/discover-more/vision -- 6.83 kB -- -1 B
/getting-started/example-projects -- 7.29 kB -- -1 B
/getting-started/faq -- 40.5 kB -- -1 B
/getting-started/installation -- 8.7 kB -- -1 B
/getting-started/learn -- 8.51 kB -- -1 B
/getting-started/support -- 12.3 kB -- -1 B
/getting-started/supported-components -- 7.97 kB -- -1 B
/getting-started/supported-platforms -- 5.97 kB -- -1 B
/getting-started/templates -- 8.81 kB -- -1 B
/getting-started/templates/album -- 5.56 kB -- -1 B
/getting-started/templates/blog -- 7.43 kB -- -1 B
/getting-started/templates/checkout -- 10.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.85 kB -- -1 B
/getting-started/templates/pricing -- 7.77 kB -- -1 B
/getting-started/templates/sign-in-side -- 8.2 kB -- -1 B
/getting-started/templates/sign-in -- 8.44 kB -- -1 B
/getting-started/templates/sign-up -- 8.54 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.34 kB -- -1 B
/guides/api -- 14.8 kB -- -1 B
/guides/composition -- 15.6 kB -- -1 B
/guides/flow -- 2.36 kB -- -1 B
/guides/interoperability -- 16 kB -- -1 B
/guides/localization -- 10.1 kB -- -1 B
/guides/migration-v0x -- 7.78 kB -- -1 B
/guides/migration-v3 -- 18.7 kB -- -1 B
/guides/minimizing-bundle-size -- 14.9 kB -- -1 B
/guides/responsive-ui -- 4.22 kB -- -1 B
/guides/right-to-left -- 5.37 kB -- -1 B
/guides/server-rendering -- 9.93 kB -- -1 B
/guides/testing -- 8.18 kB -- -1 B
/guides/typescript -- 15.8 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 8.49 kB -- -1 B
/performance/table-hook -- 2.24 kB -- -1 B
/performance/table-mui -- 4.49 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.6 kB -- -1 B
/premium-themes/onepirate -- 7.34 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 7.7 kB -- -1 B
/production-error -- 3.71 kB -- -1 B
/styles/advanced -- 32.6 kB -- -1 B
/styles/api -- 16.4 kB -- -1 B
/styles/basics -- 15.9 kB -- -1 B
/system/api -- 3.57 kB -- -1 B
/system/basics -- 27.2 kB -- -1 B
/system/borders -- 3.72 kB -- -1 B
/system/display -- 6.2 kB -- -1 B
/system/flexbox -- 5.39 kB -- -1 B
/system/palette -- 4.15 kB -- -1 B
/system/positions -- 2.27 kB -- -1 B
/system/shadows -- 3.69 kB -- -1 B
/system/sizing -- 3.35 kB -- -1 B
/system/spacing -- 6.25 kB -- -1 B
/system/typography -- 4.03 kB -- -1 B
/versions -- 22.9 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
ToggleButton ▲ +9 B (+0.01% ) 80.2 kB ▲ +12 B (+0.05% ) 25.4 kB
Alert ▲ +9 B (+0.01% ) 87.4 kB ▲ +9 B (+0.03% ) 27.5 kB
BottomNavigationAction ▲ +9 B (+0.01% ) 79.6 kB ▲ +9 B (+0.04% ) 25.2 kB
Chip ▲ +9 B (+0.01% ) 86.8 kB ▲ +9 B (+0.03% ) 26.6 kB
Fab ▲ +9 B (+0.01% ) 80.9 kB ▲ +9 B (+0.04% ) 25.2 kB
InputBase ▲ +9 B (+0.01% ) 75 kB ▲ +9 B (+0.04% ) 23.5 kB
TableSortLabel ▲ +9 B (+0.01% ) 81.5 kB ▲ +9 B (+0.04% ) 25.7 kB
Autocomplete ▲ +9 B (+0.01% ) 136 kB ▲ +8 B (+0.02% ) 42.8 kB
Backdrop ▲ +9 B (+0.01% ) 73.2 kB ▲ +8 B (+0.04% ) 22.6 kB
Checkbox ▲ +9 B (+0.01% ) 86.3 kB ▲ +8 B (+0.03% ) 27.4 kB
FilledInput ▲ +9 B (+0.01% ) 78 kB ▲ +8 B (+0.03% ) 24.2 kB
Input ▲ +9 B (+0.01% ) 76.9 kB ▲ +8 B (+0.03% ) 24 kB
Pagination ▲ +9 B (+0.01% ) 88.6 kB ▲ +8 B (+0.03% ) 27.3 kB
RadioGroup ▲ +9 B (+0.01% ) 68.4 kB ▲ +8 B (+0.04% ) 21.2 kB
Snackbar ▲ +9 B (+0.01% ) 80.9 kB ▲ +8 B (+0.03% ) 25.4 kB
SpeedDial ▲ +9 B (+0.01% ) 91.1 kB ▲ +8 B (+0.03% ) 28.9 kB
StepButton ▲ +9 B (+0.01% ) 86.4 kB ▲ +8 B (+0.03% ) 27.2 kB
StepContent ▲ +9 B (+0.01% ) 74.7 kB ▲ +8 B (+0.03% ) 23.3 kB
Switch ▲ +9 B (+0.01% ) 85.5 kB ▲ +8 B (+0.03% ) 26.8 kB
Tab ▲ +9 B (+0.01% ) 80.6 kB ▲ +8 B (+0.03% ) 25.6 kB
TabList ▲ +9 B (+0.01% ) 91.5 kB ▲ +8 B (+0.03% ) 29.2 kB
Accordion ▲ +9 B (+0.01% ) 77.2 kB ▲ +7 B (+0.03% ) 24.2 kB
AccordionActions ▲ +9 B (+0.01% ) 66.5 kB ▲ +7 B (+0.03% ) 20.8 kB
AccordionDetails ▲ +9 B (+0.01% ) 66.4 kB ▲ +7 B (+0.03% ) 20.7 kB
AppBar ▲ +9 B (+0.01% ) 68.5 kB ▲ +7 B (+0.03% ) 21.4 kB
Avatar ▲ +9 B (+0.01% ) 69.7 kB ▲ +7 B (+0.03% ) 21.8 kB
AvatarGroup ▲ +9 B (+0.01% ) 70.8 kB ▲ +7 B (+0.03% ) 22.4 kB
Badge ▲ +9 B (+0.01% ) 69.8 kB ▲ +7 B (+0.03% ) 21.7 kB
Breadcrumbs ▲ +9 B (+0.01% ) 84.6 kB ▲ +7 B (+0.03% ) 26.7 kB
ButtonBase ▲ +9 B (+0.01% ) 78 kB ▲ +7 B (+0.03% ) 24.5 kB
CardActionArea ▲ +9 B (+0.01% ) 79.1 kB ▲ +7 B (+0.03% ) 25 kB
CardActions ▲ +9 B (+0.01% ) 66.5 kB ▲ +7 B (+0.03% ) 20.8 kB
CardContent ▲ +9 B (+0.01% ) 66.4 kB ▲ +7 B (+0.03% ) 20.7 kB
CardMedia ▲ +9 B (+0.01% ) 66.8 kB ▲ +7 B (+0.03% ) 20.9 kB
CircularProgress ▲ +9 B (+0.01% ) 68.6 kB ▲ +7 B (+0.03% ) 21.5 kB
Collapse ▲ +9 B (+0.01% ) 73.5 kB ▲ +7 B (+0.03% ) 22.7 kB
Container ▲ +9 B (+0.01% ) 67.7 kB ▲ +7 B (+0.03% ) 21.1 kB
CssBaseline ▲ +9 B (+0.01% ) 66.4 kB ▲ +7 B (+0.03% ) 20.8 kB
Dialog ▲ +9 B (+0.01% ) 88.4 kB ▲ +7 B (+0.03% ) 27.6 kB
DialogActions ▲ +9 B (+0.01% ) 66.5 kB ▲ +7 B (+0.03% ) 20.8 kB
DialogContentText ▲ +9 B (+0.01% ) 68.6 kB ▲ +7 B (+0.03% ) 21.5 kB
DialogTitle ▲ +9 B (+0.01% ) 68.8 kB ▲ +7 B (+0.03% ) 21.6 kB
Divider ▲ +9 B (+0.01% ) 67.1 kB ▲ +7 B (+0.03% ) 21.1 kB
ExpansionPanelActions ▲ +9 B (+0.01% ) 66.5 kB ▲ +7 B (+0.03% ) 20.8 kB
ExpansionPanelDetails ▲ +9 B (+0.01% ) 66.4 kB ▲ +7 B (+0.03% ) 20.7 kB
FormControlLabel ▲ +9 B (+0.01% ) 70 kB ▲ +7 B (+0.03% ) 21.9 kB
FormGroup ▲ +9 B (+0.01% ) 66.5 kB ▲ +7 B (+0.03% ) 20.8 kB
FormHelperText ▲ +9 B (+0.01% ) 67.8 kB ▲ +7 B (+0.03% ) 21 kB
FormLabel ▲ +9 B (+0.01% ) 68 kB ▲ +7 B (+0.03% ) 21 kB
GridList ▲ +9 B (+0.01% ) 66.9 kB ▲ +7 B (+0.03% ) 21 kB
GridListTile ▲ +9 B (+0.01% ) 68.2 kB ▲ +7 B (+0.03% ) 21.3 kB
GridListTileBar ▲ +9 B (+0.01% ) 67.7 kB ▲ +7 B (+0.03% ) 21.2 kB
Hidden ▲ +9 B (+0.01% ) 70.5 kB ▲ +7 B (+0.03% ) 22.1 kB
Icon ▲ +9 B (+0.01% ) 67.3 kB ▲ +7 B (+0.03% ) 21 kB
IconButton ▲ +9 B (+0.01% ) 80.2 kB ▲ +7 B (+0.03% ) 25.1 kB
InputAdornment ▲ +9 B (+0.01% ) 69.6 kB ▲ +7 B (+0.03% ) 21.9 kB
InputLabel ▲ +9 B (+0.01% ) 69.8 kB ▲ +7 B (+0.03% ) 21.5 kB
LinearProgress ▲ +9 B (+0.01% ) 69.9 kB ▲ +7 B (+0.03% ) 21.8 kB
Link ▲ +9 B (+0.01% ) 71.1 kB ▲ +7 B (+0.03% ) 22.4 kB
List ▲ +9 B (+0.01% ) 66.8 kB ▲ +7 B (+0.03% ) 20.8 kB
ListItem ▲ +9 B (+0.01% ) 81.1 kB ▲ +7 B (+0.03% ) 25.4 kB
ListItemAvatar ▲ +9 B (+0.01% ) 66.6 kB ▲ +7 B (+0.03% ) 20.8 kB
ListItemIcon ▲ +9 B (+0.01% ) 66.6 kB ▲ +7 B (+0.03% ) 20.8 kB
ListItemSecondaryAction ▲ +9 B (+0.01% ) 66.5 kB ▲ +7 B (+0.03% ) 20.8 kB
ListSubheader ▲ +9 B (+0.01% ) 67.3 kB ▲ +7 B (+0.03% ) 21.1 kB
MenuItem ▲ +9 B (+0.01% ) 82.2 kB ▲ +7 B (+0.03% ) 25.7 kB
MenuList ▲ +9 B (+0.01% ) 70.5 kB ▲ +7 B (+0.03% ) 22 kB
MobileStepper ▲ +9 B (+0.01% ) 72.4 kB ▲ +7 B (+0.03% ) 22.6 kB
NativeSelect ▲ +9 B (+0.01% ) 81.4 kB ▲ +7 B (+0.03% ) 25.6 kB
OutlinedInput ▲ +9 B (+0.01% ) 79.1 kB ▲ +7 B (+0.03% ) 24.5 kB
ScopedCssBaseline ▲ +9 B (+0.01% ) 67.3 kB ▲ +7 B (+0.03% ) 21.1 kB
Slider ▲ +9 B (+0.01% ) 80.4 kB ▲ +7 B (+0.03% ) 25.5 kB
SnackbarContent ▲ +9 B (+0.01% ) 68 kB ▲ +7 B (+0.03% ) 21.4 kB
SpeedDialIcon ▲ +9 B (+0.01% ) 69.1 kB ▲ +7 B (+0.03% ) 21.6 kB
StepConnector ▲ +9 B (+0.01% ) 67.2 kB ▲ +7 B (+0.03% ) 21.1 kB
StepIcon ▲ +9 B (+0.01% ) 69.1 kB ▲ +7 B (+0.03% ) 21.5 kB
StepLabel ▲ +9 B (+0.01% ) 73.1 kB ▲ +7 B (+0.03% ) 22.6 kB
Stepper ▲ +9 B (+0.01% ) 69.2 kB ▲ +7 B (+0.03% ) 21.8 kB
SvgIcon ▲ +9 B (+0.01% ) 67.5 kB ▲ +7 B (+0.03% ) 21 kB
Table ▲ +9 B (+0.01% ) 67 kB ▲ +7 B (+0.03% ) 21 kB
TableBody ▲ +9 B (+0.01% ) 66.6 kB ▲ +7 B (+0.03% ) 20.8 kB
TableContainer ▲ +9 B (+0.01% ) 66.4 kB ▲ +7 B (+0.03% ) 20.7 kB
TableFooter ▲ +9 B (+0.01% ) 66.6 kB ▲ +7 B (+0.03% ) 20.8 kB
TableHead ▲ +9 B (+0.01% ) 66.6 kB ▲ +7 B (+0.03% ) 20.8 kB
TableRow ▲ +9 B (+0.01% ) 67 kB ▲ +7 B (+0.03% ) 21 kB
TabPanel ▲ +9 B (+0.01% ) 67.3 kB ▲ +7 B (+0.03% ) 21.1 kB
Timeline ▲ +9 B (+0.01% ) 66.9 kB ▲ +7 B (+0.03% ) 20.9 kB
TimelineConnector ▲ +9 B (+0.01% ) 66.4 kB ▲ +7 B (+0.03% ) 20.8 kB
TimelineContent ▲ +9 B (+0.01% ) 66.9 kB ▲ +7 B (+0.03% ) 20.9 kB
TimelineDot ▲ +9 B (+0.01% ) 67.5 kB ▲ +7 B (+0.03% ) 21.1 kB
TimelineItem ▲ +9 B (+0.01% ) 67.6 kB ▲ +7 B (+0.03% ) 21.1 kB
TimelineOppositeContent ▲ +9 B (+0.01% ) 67 kB ▲ +7 B (+0.03% ) 20.9 kB
TimelineSeparator ▲ +9 B (+0.01% ) 66.4 kB ▲ +7 B (+0.03% ) 20.8 kB
ToggleButtonGroup ▲ +9 B (+0.01% ) 67.9 kB ▲ +7 B (+0.03% ) 21.3 kB
Toolbar ▲ +9 B (+0.01% ) 66.8 kB ▲ +7 B (+0.03% ) 20.9 kB
TreeItem ▲ +9 B (+0.01% ) 80.5 kB ▲ +7 B (+0.03% ) 25.5 kB
Typography ▲ +9 B (+0.01% ) 68.1 kB ▲ +7 B (+0.03% ) 21.2 kB
@material-ui/lab ▲ +9 B (0.00% ) 223 kB ▲ +6 B (+0.01% ) 65.6 kB
AccordionSummary ▲ +9 B (+0.01% ) 82.2 kB ▲ +6 B (+0.02% ) 26 kB
BottomNavigation ▲ +9 B (+0.01% ) 66.9 kB ▲ +6 B (+0.03% ) 20.9 kB
Button ▲ +9 B (+0.01% ) 83.8 kB ▲ +6 B (+0.02% ) 25.7 kB
ButtonGroup ▲ +9 B (+0.01% ) 87.5 kB ▲ +6 B (+0.02% ) 27 kB
Card ▲ +9 B (+0.01% ) 67.3 kB ▲ +6 B (+0.03% ) 21 kB
CardHeader ▲ +9 B (+0.01% ) 69.6 kB ▲ +6 B (+0.03% ) 21.8 kB
DialogContent ▲ +9 B (+0.01% ) 66.7 kB ▲ +6 B (+0.03% ) 20.8 kB
ExpansionPanelSummary ▲ +9 B (+0.01% ) 82.3 kB ▲ +6 B (+0.02% ) 26 kB
FormControl ▲ +9 B (+0.01% ) 68.9 kB ▲ +6 B (+0.03% ) 21.4 kB
Grid ▲ +9 B (+0.01% ) 69.5 kB ▲ +6 B (+0.03% ) 21.8 kB
PaginationItem ▲ +9 B (+0.01% ) 85 kB ▲ +6 B (+0.02% ) 26.2 kB
Paper ▲ +9 B (+0.01% ) 66.8 kB ▲ +6 B (+0.03% ) 20.8 kB
Rating ▲ +9 B (+0.01% ) 75.4 kB ▲ +6 B (+0.02% ) 24.2 kB
Skeleton ▲ +9 B (+0.01% ) 67.7 kB ▲ +6 B (+0.03% ) 21.3 kB
SpeedDialAction ▲ +9 B (+0.01% ) 123 kB ▲ +6 B (+0.02% ) 39.1 kB
Step ▲ +9 B (+0.01% ) 67.2 kB ▲ +6 B (+0.03% ) 21.1 kB
TableCell ▲ +9 B (+0.01% ) 68.6 kB ▲ +6 B (+0.03% ) 21.5 kB
TablePagination ▲ +9 B (+0.01% ) 148 kB ▲ +6 B (+0.01% ) 43.6 kB
Tabs ▲ +9 B (+0.01% ) 90.3 kB ▲ +6 B (+0.02% ) 28.2 kB
Tooltip ▲ +9 B (+0.01% ) 107 kB ▲ +6 B (+0.02% ) 33.9 kB
TreeView ▲ +9 B (+0.01% ) 72.8 kB ▲ +6 B (+0.03% ) 22.8 kB
AlertTitle ▲ +9 B (+0.01% ) 68.7 kB ▲ +5 B (+0.02% ) 21.5 kB
ExpansionPanel ▲ +9 B (+0.01% ) 77.2 kB ▲ +5 B (+0.02% ) 24.2 kB
ListItemText ▲ +9 B (+0.01% ) 69.5 kB ▲ +5 B (+0.02% ) 21.8 kB
Radio ▲ +9 B (+0.01% ) 87.3 kB ▲ +5 B (+0.02% ) 27.6 kB
TabScrollButton ▲ +9 B (+0.01% ) 81.1 kB ▲ +5 B (+0.02% ) 25.4 kB
TextField ▲ +9 B (+0.01% ) 130 kB ▲ +5 B (+0.01% ) 38.2 kB
@material-ui/system ▲ +9 B (+0.05% ) 17.2 kB ▲ +4 B (+0.09% ) 4.51 kB
Box ▲ +9 B (+0.01% ) 73.4 kB ▲ +4 B (+0.02% ) 22.2 kB
Drawer ▲ +9 B (+0.01% ) 90.4 kB ▲ +4 B (+0.01% ) 27.5 kB
Menu ▲ +9 B (+0.01% ) 94 kB ▲ +4 B (+0.01% ) 28.9 kB
Popover ▲ +9 B (+0.01% ) 88.3 kB ▲ +4 B (+0.01% ) 27.3 kB
Select ▲ +9 B (+0.01% ) 121 kB ▲ +4 B (+0.01% ) 36.1 kB
styles/createMuiTheme ▲ +9 B (+0.04% ) 21.9 kB ▲ +4 B (+0.05% ) 7.58 kB
SwipeableDrawer ▲ +9 B (+0.01% ) 97.8 kB ▲ +4 B (+0.01% ) 30.7 kB
@material-ui/core ▲ +9 B (0.00% ) 375 kB ▲ +3 B (0.00% ) 102 kB
Zoom ▲ +9 B (+0.03% ) 29 kB ▲ +3 B (+0.03% ) 9.81 kB
Fade ▲ +9 B (+0.03% ) 28.9 kB ▲ +2 B (+0.02% ) 9.66 kB
Grow ▲ +9 B (+0.03% ) 29.6 kB ▲ +2 B (+0.02% ) 9.88 kB
packages/material-ui/material-ui.production.min.js ▲ +9 B (0.00% ) 330 kB ▲ +2 B (0.00% ) 95.4 kB
Slide ▲ +9 B (+0.03% ) 30.7 kB ▲ +2 B (+0.02% ) 10.3 kB
@material-ui/styles -- 52.1 kB -- 15.6 kB
@material-ui/utils -- 7.19 kB -- 2.61 kB
ClickAwayListener -- 4.16 kB -- 1.67 kB
colorManipulator -- 4.14 kB -- 1.63 kB
docs:/ -- 13.1 kB -- -1 B
docs:/_app -- 36.9 kB -- -1 B
Modal -- 15.1 kB -- 5.28 kB
NoSsr -- 2.18 kB -- 1.03 kB
Popper -- 28.7 kB -- 10.3 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.64 kB -- 1.76 kB
TabContext -- 2.65 kB -- 1.15 kB
TextareaAutosize -- 5.23 kB -- 2.19 kB
Unstable_TrapFocus -- 3.87 kB -- 1.59 kB
useAutocomplete -- 14.7 kB -- 5.27 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB

Generated by 🚫 dangerJS against 52f6592

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 21, 2021 •
edited

I'm waiting for codesandbox ci build to complete to test the change, we need to make sure that it works end-to-end. For some reasons, I couldn't reproduce the error in Next.js's docs.

@github-actions github-actions bot mentioned this pull request Jan 21, 2021
Closed
@oliviertassinari
Copy link
Member Author

Ok, it's fixed.

before: https://codesandbox.io/s/box-issue-with-undefined-forked-hxp13
after: https://codesandbox.io/s/box-issue-with-undefined-forked-6vdgr

@oliviertassinari oliviertassinari merged commit 569c72e into mui:master Jan 21, 2021
@oliviertassinari oliviertassinari deleted the box-fix-NaN branch January 21, 2021 14:05
oliviertassinari added a commit to oliviertassinari/material-ui that referenced this pull request Jan 21, 2021
@oliviertassinari
[system] Fix handling of null-ish values (mui#24527)
8799758
@oliviertassinari oliviertassinari mentioned this pull request Jan 21, 2021
Merged
@bauwaerter bauwaerter mentioned this pull request Jan 21, 2021
Closed
2 tasks
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jan 21, 2021 •
edited

For developers that want to use this patch until we release v4.11.3, follow https://github.com/mui-org/material-ui/blob/next/CONTRIBUTING.md#how-can-i-use-a-change-that-wasnt-released-yet

@Poky85
Copy link

Poky85 commented Jan 22, 2021

To use commit as a dependency follow instructions here https://ci.codesandbox.io/status/mui-org/material-ui/pr/24527, section Local Install Instructions

E.g.

"@material-ui/core": "https://pkg.csb.dev/mui-org/material-ui/commit/52f6592c/@material-ui/core",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Box The React component. package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oliviertassinari @mui-pr-bot @Poky85 @mnajdova @eps1lon