Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pickers] Fix role attribute #24621

Merged
merged 10 commits into from
Jan 26, 2021
Merged

[Pickers] Fix role attribute #24621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5c40a7c
[DateRangePickerDay][PickersCalendar]: Add role attribute
EkaterinaMozheiko Jan 25, 2021
19f3f16
polish docs
oliviertassinari Jan 26, 2021
659e54c
unskip test
oliviertassinari Jan 26, 2021
d6ac73b
assert the correct DOM structure
oliviertassinari Jan 26, 2021
cee4981
add more context
oliviertassinari Jan 26, 2021
309b792
respect naming convention
oliviertassinari Jan 26, 2021
99911f5
oh ok, this sucks
oliviertassinari Jan 26, 2021
cac6898
more polish
oliviertassinari Jan 26, 2021
4c130ff
add test case
oliviertassinari Jan 26, 2021
dc35dda
polish
oliviertassinari Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/material-ui-lab/src/DateRangePickerDay/DateRangePickerDay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ const DateRangePickerDay = React.forwardRef(function DateRangePickerDay<TDate>(
})}
>
<div
role="cell"
data-mui-test={shouldRenderPreview ? 'DateRangePreview' : undefined}
className={clsx(classes.rangeIntervalPreview, {
[classes.rangeIntervalDayPreview]: shouldRenderPreview,
Expand Down
5 changes: 3 additions & 2 deletions packages/material-ui-lab/src/DayPicker/PickersCalendar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ function PickersCalendar<TDate>(props: PickersCalendarProps<TDate> & WithStyles<
const dayProps: PickersDayProps<TDate> = {
key: (day as any)?.toString(),
day,
role: 'cell',
isAnimating: isMonthSwitchingAnimating,
disabled: isDateDisabled(day),
allowKeyboardControl,
Expand All @@ -225,7 +224,9 @@ function PickersCalendar<TDate>(props: PickersCalendarProps<TDate> & WithStyles<
return renderDay ? (
renderDay(day, selectedDates, dayProps)
) : (
<PickersDay {...dayProps} />
<div role="cell" key={dayProps.key}>
<PickersDay {...dayProps} />
</div>
);
})}
</div>
Expand Down