Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Migrate DialogContent to emotion #24670

Merged
merged 4 commits into from Jan 28, 2021
Merged

[Dialog] Migrate DialogContent to emotion #24670

merged 4 commits into from Jan 28, 2021

Conversation

vicasas
Copy link
Member

@vicasas vicasas commented Jan 28, 2021

One of #24405

@mui-pr-bot
Copy link

mui-pr-bot commented Jan 28, 2021 •
edited

@material-ui/core: parsed: +0.11% , gzip: -0.06% 😍
@material-ui/lab: parsed: +0.09% , gzip: +0.05%

Details of bundle changes

Generated by 🚫 dangerJS against 3c07f74

@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label Jan 28, 2021
@oliviertassinari oliviertassinari mentioned this pull request Jan 28, 2021
Closed
mnajdova
mnajdova approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @vicasas thanks!

@github-actions github-actions bot mentioned this pull request Jan 28, 2021
Closed
@mnajdova mnajdova merged commit 1bd1e64 into mui:next Jan 28, 2021
natac13 pushed a commit to natac13/material-ui that referenced this pull request Jan 30, 2021
@vicasas @natac13
[Dialog] Migrate DialogContent to emotion (mui#24670)
4694fa8
@vicasas vicasas deleted the feature/dialogcontent-migrate-emotion branch April 17, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vicasas @mui-pr-bot @mnajdova @oliviertassinari