[core] Disable type-checking of .propTypes #24747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/lab: parsed: -0.99% 😍, gzip: -0.61% 😍 |
eps1lon
changed the title
eps1lon
force-pushed
the
core/disable-proptypes-checking
branch
from
40ef0db
to
d6d1cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Component as any).propTypesis not recognized byreact-docgen.Update: Considering the bundle size reduction it's probably also not recognized by
babel-plugin-transform-react-remove-prop-typesUpdate: .propTypes were not removed before: https://unpkg.com/browse/@material-ui/lab@5.0.0-alpha.24/ClockPicker/ClockPicker
We can achieve sounder types with
Component.propTypes = {} as anyby adjusting the type ofComponent. .propTypes and Props types need to match exactly which breaks down when .propTypes need the actual runtime or we didn't resolve a big object (e.g.classes).