Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popper] Fix usage of ownerDocument with anchorEl #24753

Merged
merged 1 commit into from Feb 4, 2021
Merged

[Popper] Fix usage of ownerDocument with anchorEl #24753

merged 1 commit into from Feb 4, 2021

Conversation

ruppysuppy
Copy link
Contributor

@ruppysuppy ruppysuppy commented Feb 3, 2021 •
edited by oliviertassinari

Fix #24550

@mui-pr-bot
Copy link

mui-pr-bot commented Feb 3, 2021 •
edited

Details of bundle changes

Generated by 🚫 dangerJS against 4185abe

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: Popper The React component. See <Popup> for the latest version. labels Feb 3, 2021
oliviertassinari
oliviertassinari approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before: https://mhk0g.csb.app/
After: https://qdp8v.csb.app/

Capture d’écran 2021-02-04 à 00 16 55

@eps1lon eps1lon merged commit 53d2741 into mui:next Feb 4, 2021
@eps1lon
Copy link
Member

eps1lon commented Feb 4, 2021

@ruppysuppy Thanks!

@eps1lon eps1lon added the PR: needs test The pull request can't be merged label Feb 4, 2021
@oliviertassinari oliviertassinari removed the PR: needs test The pull request can't be merged label Feb 10, 2021
@oliviertassinari oliviertassinari changed the title [Popper] Use ownerDocument of anchorEl [Popper] Fix usage of ownerDocument with anchorEl Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Popper The React component. See <Popup> for the latest version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Popper] Use ownerDocument of anchorEl
4 participants
@ruppysuppy @mui-pr-bot @eps1lon @oliviertassinari