[test] Isolate Tooltip tests more #24834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
added
test
component: tooltip
eps1lon
commented
Feb 8, 2021
| @@ -477,6 +477,7 @@ describe('<Tooltip />', () => { | |||
| }); | |||
|
|
|||
| expect(getByRole('tooltip')).toBeVisible(); | |||
| expect(handleFocus.callCount).to.equal(1); | |||
There was a problem hiding this comment.
To match the test description "should handle autoFocus + onFocus forwarding". The "+ onFocus forwarding" part was not tested as far as I can tell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to test it with
<Input />. If it would be important it should be part of the integration test suite.The goal is to reduce the number of style tags in the DOM which speeds up style computation in JSDOM.