[test] Initial workspace definition #24869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eps1lon
commented
Feb 12, 2021
Comment on lines
-78
to
+119
| const testPath = `"${this.currentTest.parent | ||
| .titlePath() | ||
| .concat(this.currentTest.title) | ||
| .join('" -> "')}"`; | ||
| // @ts-expect-error -- this.currentTest being undefined would be a bug | ||
| const testPath = `"${this.currentTest.fullTitle()}"`; |
There was a problem hiding this comment.
drive-by refactoring. Didn't know at the time that fullTitle existed. It's a bit different to the previous formatting but we use fullTitle in other parts as well so let's not surprise testers with new formatting.
We have banned some import paths in material-ui-x to only allow |
|
Ultimately a package manager would do this job (e.g. yarn v2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version only has a dedicated task for type-checking utils. Over time we'll consolidate dependencies to make it clearer what utils you should import from where (e.g.
fireEventfrom@testing-library/reactortest/utils?).